consensus/ethash: remove spurious conditions preventing EIP3860, EIP4844 w/ Ethash #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…844 w/ Ethash These conditions prevented the enabling of these EIPs with the Ethash consensus engine by throwing an error if they were enabled during header verification. This behavior is incompatible with ETC's planned use of these features, so we should remove these conditions from header verification and allow these EIPs to be enabled with Ethash configuration. I see no conceptual reason why 3860= limit and meter init code and 4844= blob tx types can not be used with Ethash pow block sealing. Date: 2023-10-10 11:25:31-06:00 Signed-off-by: meows <[email protected]>
diega
approved these changes
Oct 10, 2023
ziogaschr
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These conditions prevented the enabling
of these EIPs with the Ethash consensus
engine by throwing an error if they were
enabled during header verification.
This behavior is incompatible with ETC's
planned use of these features, so we should
remove these conditions from header verification
and allow these EIPs to be enabled with
Ethash configuration.
I see no conceptual reason why 3860=
limit and meter init code and 4844=
blob tx types can not be used with Ethash
pow block sealing.
Date: 2023-10-10 11:25:31-06:00