Fix/eth_getBlockByNumber and eth_getUncle... nullable fields #341
Commits on Mar 15, 2021
-
ethclient,internal/ethapi: add Nonce (null) to pending block JSON
Date: 2021-03-15 09:53:13-05:00 Signed-off-by: meows <[email protected]>
-
ethclient: add test case for expected non-null values ('number')
Date: 2021-03-15 09:56:24-05:00 Signed-off-by: meows <[email protected]>
-
ethclient: refactor test, unifying to map of expected value (null, ze…
…ro-value, and filled) Date: 2021-03-15 10:07:04-05:00 Signed-off-by: meows <[email protected]>
-
ethclient: add missing fields to test and compare diff
Date: 2021-03-15 10:15:24-05:00 Signed-off-by: meows <[email protected]>
-
ethclient,internal/ethapi: add Hash (null) to pending block JSON
Date: 2021-03-15 10:16:52-05:00 Signed-off-by: meows <[email protected]>
-
ethclient: assert positive generic match on special case timestamp
Date: 2021-03-15 10:21:40-05:00 Signed-off-by: meows <[email protected]>
-
ethclient,internal/ethapi: jsonrpc header marshaling assign totalDiff…
…iculty by calculation if DNE Date: 2021-03-15 10:44:45-05:00 Signed-off-by: meows <[email protected]>
-
internal/ethapi: add Miner (null) to pending block JSON
Date: 2021-03-15 10:55:14-05:00 Signed-off-by: meows <[email protected]>
-
ethclient,internal/ethapi: wip: totalDifficulty is fucked up; either …
…incrementing too big or nil Date: 2021-03-15 11:15:25-05:00 Signed-off-by: meows <[email protected]>
-
ethclient: move test to 'cg' namespaced file, allows testing @ethereu…
…m/go-ethereum Date: 2021-03-15 13:35:41-05:00 Signed-off-by: meows <[email protected]>
-
ethclient: refactor test to be generic using pattern matching
Date: 2021-03-15 14:16:06-05:00 Signed-off-by: meows <[email protected]>
-
ethclient: add Latest suffix for a more descriptive test name
Date: 2021-03-15 14:17:42-05:00 Signed-off-by: meows <[email protected]>
-
ethclient: extrapolate regex-based test to earliest,latest,pending
Date: 2021-03-15 14:48:05-05:00 Signed-off-by: meows <[email protected]>
-
ethclient: rename test to be more conventional and descriptive
Date: 2021-03-15 14:50:05-05:00 Signed-off-by: meows <[email protected]>
-
internal/ethapi: remove dead wip-commented code
Date: 2021-03-15 14:50:19-05:00 Signed-off-by: meows <[email protected]>
-
.github/workflows,ethclient: init Github Actions CI workflow to test …
…go-ethereum 1:1 cases Date: 2021-03-15 15:16:47-05:00 Signed-off-by: meows <[email protected]>
-
ethclient: use go subtest syntax for better descriptiveness and logging
Date: 2021-03-15 15:23:31-05:00 Signed-off-by: meows <[email protected]>
-
ethclient: additional commentary
Date: 2021-03-15 15:25:59-05:00 Signed-off-by: meows <[email protected]>
Commits on Mar 16, 2021
-
.github/workflows,ethclient: remove go-ethereum 1:1 comparative testing
This is just a little over-the-top and too ad-hoc to be worth existence. Date: 2021-03-16 10:33:15-05:00 Signed-off-by: meows <[email protected]>
-
ethclient: assert hash len for block hash field
Date: 2021-03-16 10:55:16-05:00 Signed-off-by: meows <[email protected]>
Commits on Mar 17, 2021
-
internal/ethapi: omit the transactions field when marshaling uncle bl…
…ocks Create a dedicated type for this case, switching on it conditionally when inclTx is false; this parameter is false only for uncle blocks. Date: 2021-03-17 13:08:01-05:00 Signed-off-by: meows <[email protected]>
-
ethclient: test that the transactions field is omitted for uncles res…
…ponses Date: 2021-03-17 13:30:37-05:00 Signed-off-by: meows <[email protected]>