-
-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(es_extended): Extra callback functions #1505
base: dev
Are you sure you want to change the base?
feat(es_extended): Extra callback functions #1505
Conversation
I don't see the point of this. ESX already throws an error if a resource attempts to access an invalid callback. This just promotes people calling Third party resources can check if their dependencies are started and just assume that all expected callbacks are registered. We are already letting them know if they are not ^^ |
I agree with Kenshin on this one, there is 0 usecase for it and litterly no one ever requested a functionality like this |
---@return table | nil | ||
function ESX.GetClientCallbackInfo(eventName) | ||
return Callbacks.storage[eventName] | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't need to be a thing
---@return table | nil | ||
function ESX.GetServerCallbackInfo(eventName) | ||
return Callbacks.storage[eventName] | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't need to be a thing
Introduces 4 new functions:
ESX.DoesClientCallbackExist
ESX.GetClientCallbackInfo
ESX.DoesServerCallbackExist
ESX.GetServerCallbackInfo