Merge pull request #3 from espressif/fix/windows_paths

fix: windows paths
espressif · Jan 13, 2025 · 95bb1e4 · 95bb1e4
2 parents 0c838b8 + 13e87f6
commit 95bb1e4
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 8 deletions.
diff --git a/.github/workflows/test-python.yml b/.github/workflows/test-python.yml
@@ -19,10 +19,14 @@ permissions:
 
 jobs:
   test-python:
-    runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: ["3.8", "3.13"]
+        include:
+          - os: windows-latest
+            python-version: "3.8"
+          - os: ubuntu-latest
+            python-version: "3.13"
+    runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v4
       - name: Set up Python ${{ matrix.python-version }}

diff --git a/idf_ci/idf_pytest/plugin.py b/idf_ci/idf_pytest/plugin.py
@@ -114,8 +114,7 @@ def pytest_pycollect_makemodule(
                     # redirect_stderr somehow breaks the sys.stderr.write() method
                     # fix it when implement proper logging
                     pkg = res.group(1)
-                    if sys.__stderr__:
-                        sys.__stderr__.write(f'WARNING:Mocking missed package while collecting: {pkg}\n')
+                    logging.warning(f'WARNING:Mocking missed package while collecting: {pkg}\n')
                     sys.modules[pkg] = MagicMock()
                     continue
             else:

diff --git a/idf_ci/settings.py b/idf_ci/settings.py
@@ -1,6 +1,7 @@
 # SPDX-FileCopyrightText: 2025 Espressif Systems (Shanghai) CO LTD
 # SPDX-License-Identifier: Apache-2.0
-import os.path
+
+import os
 import re
 import typing as t
 from pathlib import Path
@@ -58,11 +59,12 @@ def get_modified_components(self, modified_files: t.Iterable[str]) -> t.Set[str]
             if p.suffix in self.component_ignored_file_extensions + self.extend_component_ignored_file_extensions:
                 continue
 
-            # always use posix str
-            modified_file = Path(modified_file).as_posix()
+            # always use absolute path as posix string
+            # Path.resolve return relative path when file does not exist. so use os.path.abspath
+            modified_file = Path(os.path.abspath(modified_file)).as_posix()
 
             for regex in self.all_component_mapping_regexes:
-                match = regex.search(os.path.abspath(modified_file))
+                match = regex.search(modified_file)
                 if match:
                     modified_components.add(match.group(1))
                     break