Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(websocket): use proper interface to delete semaphore #683

Merged
merged 1 commit into from
Oct 31, 2024
Merged

fix(websocket): use proper interface to delete semaphore #683

merged 1 commit into from
Oct 31, 2024

Conversation

bryghtlabs-richard
Copy link
Contributor

Description

Switch WebSocket client to use vSemaphoreDelete() to delete its mutex.

Testing

No testing was done.

Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@bryghtlabs-richard
fix(websocket): use proper interface to delete semaphore
991ac40 
On most implementations, including ESP-IDF FreeRTOS, vSemaphoreDelete()
is a macro that calls vQueueDelete(). But since the client semaphore is
created with xSemaphoreCreateRecursiveMutex(), delete it as a semaphore with vSemaphoreDelete().
@david-cermak david-cermak self-assigned this Oct 31, 2024
david-cermak
david-cermak approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@david-cermak david-cermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the readability tweak, here!

@david-cermak david-cermak merged commit 72f4f7c into espressif:master Oct 31, 2024
74 checks passed
@bryghtlabs-richard bryghtlabs-richard deleted the fix/ws-mutex-delete branch October 31, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-cermak david-cermak david-cermak approved these changes

Assignees

@david-cermak david-cermak

Labels
websocket
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryghtlabs-richard @david-cermak