-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wifi_remote): Make wifi_remote depend on esp_hosted (IDFGH-13027) #596
feat(wifi_remote): Make wifi_remote depend on esp_hosted (IDFGH-13027) #596
Conversation
026d074
to
bec400d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please just squash the commits, and update the dependency condition to the latest esp_hosted
version (I see that's already at 0.0.6).
LGTM otherwise, thanks for the updates!
bec400d
to
1e558bb
Compare
Co-authored-by: david-cermak <[email protected]>
f4e1525
to
ac9972a
Compare
@SohKamYung-Espressif Thanks for the contribution, pipeline has passed and I'm about to merge it. but before doing so, I'd like to ask you to just check it locally that it still works (removing the project's dependency on |
@david-cermak Sure. Which project(s) should I test this change on (locally adding the dependency on esp_hosted into esp_wifi_remote component AND removing the dependency on esp_hosted in the project's I have tested this with my S3 <---> C6 SDIO test board (native wifi on S3 disabled) with the iperf example project and it builds and runs as expected. |
Thanks for testing! |
No description provided.