feat(esp_modem): example add esp32p4 usb support (IDFGH-12673) #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
3 tasks
github-actions
bot
changed the title
david-cermak
approved these changes
May 10, 2024
There was a problem hiding this comment.
Changes in this PR LGTM!
@leeebo Could we merge it, or is this still WIP?
|
Hi @david-cermak Thanks for your review, this MR is blocked by espressif/esp-usb#30, I will finish the test work ASAP. |
|
@leeebo this still LGTM, could we merge it now or wait for the espressif/esp-usb#44 ? |
|
BTW (already told Tomas), the know issue section indicated in could be perhaps solved (worked around) by this option |
1. support ec20 cat.4 module in example modem_console and pppos_client 2. support esp32p4 in example modem_console and pppos_client
|
Hi @david-cermak , it should be ready to merge now. It doesn't need to wait as |
david-cermak
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Block by espressif/esp-usb#42