fix(lvgl_port_disp): rgb panel callback bad ctx param (BSP-582)

[liamHowatt]

ESP-BSP Pull Request checklist

Note: For new BSPs create a PR with this link.

• Version of modified component bumped
• CI passing

Change description

Fix a crash when using https://github.com/lvgl/lv_port_espressif_esp32-s3-lcd-ev-board with ESP IDF >= v5.1.2. Versions of ESP IDF older than v5.1.2 are not effected by the bug because the dependencies are solved in such a way that the file components/esp_lvgl_port/src/lvgl9/esp_lvgl_port_disp.c (where the issue is) is not compiled.

The issue occurs when the callback lvgl_port_flush_rgb_vsync_ready_callback receives a user_ctx which is &disp_ctx->disp_drv which is lv_display_t ** when the function expects it to be lv_display_t *. A hardfault happens at the dereference here:

esp-bsp/components/esp_lvgl_port/src/lvgl9/esp_lvgl_port_disp.c

Line 424 in 4bbe669

if (disp_ctx->trans_sem) {

The hardfault could also happen 3 lines earlier inside lv_display_get_user_data if the struct layout aliasing lottery plays out that way.

Reproduce by:

1. clone https://github.com/lvgl/lv_port_espressif_esp32-s3-lcd-ev-board
2. idf.py flash monitor

A boot loop will occur with a crash at the line I linked.

Specific board:
Mainboard "ESP32-S3-LCD_Ev_Board_MB_V1.0" with the sub-board "ESP32-S3-LCD_Ev_Board_SUB3_V1.0"

cc @espzav

[CLAassistant]

All committers have signed the CLA.

[DamienEspitallier]

I have the same issue and was working on a PR at the same time ! (DamienEspitallier@8b186fa)

Please note that this also affect lvgl8

[liamHowatt]

Thanks for the Info! Updated!