Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jeetrohan mpu60xx 1 (BSP-568) #416

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

jeetrohan
Copy link

@jeetrohan jeetrohan commented Oct 22, 2024

ESP-BSP Pull Request checklist

Note: For new BSPs create a PR with this link.

  • Version of modified component bumped
  • CI passing

Related

Change description

A new mpu60xx library which uses the new I2C driver for reading raw and floating point values; from accelerometer, gyrometer and temperature sensor.
Added functionality to use inbuilt motion detection on mpu60xx using both, polling and interrupts.

header file for mpu60xx driver
definitions for mpu60xx driver functions
manifest file for mpu60xx driver
example C source file for using inbuilt motion detection.
Manifest file for mpu60xx_motion_detection example
CMakeLists for mpu60xx_motion_detect
mpu60xx driver information.
@CLAassistant
Copy link

CLAassistant commented Oct 22, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot changed the title Jeetrohan mpu60xx 1 Jeetrohan mpu60xx 1 (BSP-568) Oct 22, 2024
Copy link
Collaborator

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeetrohan That's a pretty good job for your first contribution!

components/mpu60xx/CMakeLists.txt Show resolved Hide resolved
components/mpu60xx/idf_component.yml Show resolved Hide resolved
components/mpu60xx/idf_component.yml Show resolved Hide resolved
@jeetrohan
Copy link
Author

I just realized the merge here is different from the fork where sync simply updates the branch. 😅

@jeetrohan
Copy link
Author

jeetrohan commented Oct 25, 2024

@espzav , @tore-espressif
If I'm not wrong the pre-commit failed because of incorrect indentation, which it has fixed (or so it indicates in output).
A rerun should do it.

@tore-espressif
Copy link
Collaborator

@espzav , @tore-espressif If I'm not wrong the pre-commit failed because of incorrect indentation, which it has fixed (or so it indicates in output). A rerun should do it.

The pre-commit job is always run on latest changes, so there are probably still some formating errors.

If you want to fix them locally, in your esp-bsp folder you can do

pip install pre-commit && pre-commit install

To install pre-commit. Then you can run the pre-commit check on you last 11 commits like this

pre-commit run --from-ref HEAD~11 --to-ref HEAD

@tore-espressif
Copy link
Collaborator

@jeetrohan Thanks again for the PR, I'll take over and fix the remaining things when I'm free

@jeetrohan
Copy link
Author

@espzav , @tore-espressif If I'm not wrong the pre-commit failed because of incorrect indentation, which it has fixed (or so it indicates in output). A rerun should do it.

The pre-commit job is always run on latest changes, so there are probably still some formating errors.

If you want to fix them locally, in your esp-bsp folder you can do

pip install pre-commit && pre-commit install

To install pre-commit. Then you can run the pre-commit check on you last 11 commits like this

pre-commit run --from-ref HEAD~11 --to-ref HEAD

@tore-espressif
Thank you.
I'll do this at the earliest. I'd have done it since the beginning but as I mentioned it was my first time using the git. So, I think I'll still need to look more into some documentation to do this properly.
I'll follow these for the next update onward too, so that merging process is not hindered by these simple problems which should be resolved at my end itself.

@jeetrohan
Copy link
Author

@jeetrohan Thanks again for the PR, I'll take over and fix the remaining things when I'm free

@tore-espressif I totally understand that. I myself had thought to do pre-commit test on branch, but due to some other liabilities and my lack of knowledge (about git itself) I wasn't able to do it ( even though I really want to).
I'll keep you posted, once I'll add more functionality (& this time with pre-commit check. I believe I should've been the one to do it.)
Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants