-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(esp32_p4_function_ev_board): add example of wifi connection #407
base: master
Are you sure you want to change the base?
Conversation
@tore-espressif WDYT about adding such an example to bsp/esp32_p4_function_ev_board/examples directory? |
If ESP32-P4 + ESP32-C6 hardware setup is planned for all our P4 devkits, I (as a user) would expect this to be in esp-idf examples. If the ESP32-C6 modem extension is not going to be typical usecase, we can leave the example here |
6dd7745
to
0b15e99
Compare
I think we will keep ESP32-C6 on ESP32-P4 EV board, but we can't be sure that makers of other P4 boards will also add ESP32-C6. If they do, still they might opt to use a different set of pins for SDIO. On IDF side, so far support for P4 is being added only in So I thought that making this example easily available via the component manager would be a reasonable solution in the meantime. |
@tore-espressif Might need to ask for your help with the pre-commit hook. I'm guessing that the script is considering example README.md file as a BSP readme file... Could you suggest what I can change to make this check succeed? |
@igrr Please ignore the pre-commit fail, probably some issue on our side |
We can force merge, if you need it now. I'll take a look on Monday |
No, this one is not urgent at all, let's find the proper solution next week. (I have looked at the script for a bit and I think I see how to make it work, just don't have time to do it right now.) |
version: "*" | ||
override_path: "../../../" | ||
espressif/esp_wifi_remote: | ||
version: "*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably makes sense to pin at least some version of esp_wifi_remote (and maybe esp_hosted?) here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, do you plan update and set some major version here?
0b15e99
to
c0306e4
Compare
@igrr I rebased your PR, the pre-commit check is passing now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@igrr Thank you for this example, good work! LGTM
version: "*" | ||
override_path: "../../../" | ||
espressif/esp_wifi_remote: | ||
version: "*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, do you plan update and set some major version here?
bsp/esp32_p4_function_ev_board/examples/wifi_connection/main/idf_component.yml
Outdated
Show resolved
Hide resolved
c0306e4
to
be3088a
Compare
be3088a
to
4a67f95
Compare
This PR adds a simple example of connecting to Wi-Fi on ESP32-P4 EV board.
This example adds esp_wifi_remote as a dependency and sets the required sdkconfig options.
The goal is to allow users to quickly get started with Wi-Fi connectivity on this board by running