-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(LVGL port): Fixed monochromatic screen in LVGL9 + example #392
base: master
Are you sure you want to change the base?
Conversation
8c56428
to
240d997
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@espzav Changes LGTM.
Although I don't really understand the monochrome color.
Is this something that was broken by LVGL? Should we migrate to their built-in monochrome color?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi,
with dependencies:
lvgl/lvgl: "==9.2.2"
esp_lcd_sh1107: "==1.1.0"
esp_lvgl_port: "==2.4.2"
i haved make changes and with SSD1306 Display works fine.
Tanks
I also verified the fix on the ssd1306 (128x64), and graphics now works fine with lvgl9.
|
Confirmed the fix is working. For the
This might need to be added to the readme of that example. |
240d997
to
8bb2402
Compare
Hi @tore-espressif, I added support for I1 color type for monochromatic screens and fixed some minor issues. PTAL |
Confirmed, example now works with LVGL 9.2.2 and SSD1306 132x32 display. LGTM. Thanks! Works with |
|
||
ESP_LOGI(TAG, "Install panel IO"); | ||
esp_lcd_panel_io_handle_t io_handle = NULL; | ||
esp_lcd_panel_io_i2c_config_t io_config = { | ||
.dev_addr = EXAMPLE_I2C_HW_ADDR, | ||
.scl_speed_hz = EXAMPLE_LCD_PIXEL_CLOCK_HZ, | ||
.control_phase_bytes = 1, // According to SSD1306 datasheet | ||
.lcd_cmd_bits = EXAMPLE_LCD_CMD_BITS, // According to SSD1306 datasheet | ||
.lcd_param_bits = EXAMPLE_LCD_CMD_BITS, // According to SSD1306 datasheet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 73 should be EXAMPLE_LCD_PARAM_BITS constant. (Not sure why it's referring a different line). No functional change, as they are the same value.
I've also tested this on an SSH1107 132x64 screen. This works, however, as this screen is oriented differently, I wanted to rotate the screen. Here I noticed the screen rotation is broken in LVGL 9. With LVGL 8.4, I can just set When I set |
ESP-BSP Pull Request checklist
Change description