Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: improve pr-remove-preview workflow #367

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

f-hollow
Copy link
Collaborator

@f-hollow f-hollow commented Dec 18, 2024

Description

Currently, the pr-remove-preview workflow fails, because it doesn't have access to the repo secrets. I didn't test this workflow properly before, because its priority was not high. Now I got around to it.

I split the workflow into two (the same way as pr-build-preview and pr-deploy-preview):

  • The PR-side job triggered by the pull-request event
  • The upstream repo side job triggered by the workflow_run event

On PR closure or merge, the preview is removed as well as all comments with links to PR preview.

Changed the prefix for all workflows triggered by workflow_run to prw-.

Related

Testing

All testing was done here.


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@f-hollow
Copy link
Collaborator Author

f-hollow commented Dec 18, 2024

I already tested it, so I will merge it.

Once merged, the final test will be to make sure that both the preview and the comments with PR preview link are removed.

Update:

The mentioned actions were successfully completed by the workflow!

@f-hollow f-hollow merged commit 88830ba into espressif:main Dec 18, 2024
4 checks passed
@f-hollow f-hollow deleted the ci/fix_pr_remove_preview branch December 18, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant