Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SimpleTime): fixes example for SimpleTime.ino #9884

Closed
wants to merge 1 commit into from

Conversation

SuGlider
Copy link
Collaborator

Description of Change

Fixes the SimpleTime.ino example in order to make it work within Arduino core 3.0.0.
There is a DHCP option that shall not be used anymore.

Tests scenarios

Using the ESP32 and the SimpleTime.ino example.

Related links

Fixes #9879

Fixes the SimpleTime.ino example in order to make it work within Arduino core 3.0.0.
@SuGlider SuGlider added this to the 3.0.2 milestone Jun 17, 2024
@SuGlider SuGlider self-assigned this Jun 17, 2024
Copy link
Contributor

github-actions bot commented Jun 17, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "fix(SimpleTime): fixes example for SimpleTime.ino":
    • scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - .

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

⚠️

The source branch "SuGlider-SimpleTime_example" incorrect format:

  • contains uppercase letters. This can cause troubles on case-insensitive file systems (macOS).
    Please rename your branch.

👋 Hello SuGlider, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 184619f

@SuGlider SuGlider mentioned this pull request Jun 17, 2024
1 task
@SuGlider SuGlider requested a review from lucasssvaz June 17, 2024 22:22
Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S3000.000.00000.000.00
ESP32S2000.000.00000.000.00
ESP32C3000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
ESP32/examples/Time/SimpleTime----------

@SuGlider SuGlider requested a review from me-no-dev June 17, 2024 22:22
@SuGlider
Copy link
Collaborator Author

@me-no-dev - Maybe you have a better solution...

Copy link
Contributor

Test Results

 56 files   56 suites   5m 15s ⏱️
 21 tests  21 ✅ 0 💤 0 ❌
135 runs  135 ✅ 0 💤 0 ❌

Results for commit 184619f.

@SuGlider
Copy link
Collaborator Author

Closing it... it seems that this is not really fixing anything.
#9879 (comment)

@SuGlider SuGlider closed this Jun 18, 2024
@SuGlider SuGlider removed this from the 3.0.2 milestone Jun 18, 2024
@SuGlider SuGlider deleted the SuGlider-SimpleTime_example branch June 19, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

sntp problem with 3.0
1 participant