-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(SimpleTime): fixes example for SimpleTime.ino #9884
Conversation
Fixes the SimpleTime.ino example in order to make it work within Arduino core 3.0.0.
👋 Hello SuGlider, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
@me-no-dev - Maybe you have a better solution... |
Test Results 56 files 56 suites 5m 15s ⏱️ Results for commit 184619f. |
Closing it... it seems that this is not really fixing anything. |
Description of Change
Fixes the SimpleTime.ino example in order to make it work within Arduino core 3.0.0.
There is a DHCP option that shall not be used anymore.
Tests scenarios
Using the ESP32 and the SimpleTime.ino example.
Related links
Fixes #9879