-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix C2 compilation for Updater.cpp #9228
Conversation
👋 Hello lucasssvaz, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
@Jason2866 Could you check please if it fixes the issue ? I don't currently have the C2 environment configured on my computer. |
@lucasssvaz The PR solves the issue. The "price" (used additionally resources) for the encrypt feature which is probably used very seldom is imho to high. |
There only will be additional uses of resources for C2 as the functions from mbedtls are replaced with esp ones when hardware acceleration is available. We discussed it in the meeting and it is an acceptable solution for now. In the future we will remove the mbedtls dependency. |
Fixes issue reported in #5807 (comment)
This will work exactly the same for all chips except C2, where it will use the mbedtls functions. In the future we will need to replace mbedtls with something simpler.