Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix C2 compilation for Updater.cpp #9228

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Conversation

lucasssvaz
Copy link
Collaborator

Fixes issue reported in #5807 (comment)

This will work exactly the same for all chips except C2, where it will use the mbedtls functions. In the future we will need to replace mbedtls with something simpler.

@lucasssvaz lucasssvaz self-assigned this Feb 9, 2024
Copy link
Contributor

github-actions bot commented Feb 9, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Fix C2 compilation for Updater.cpp":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello lucasssvaz, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 7eb1c49

@lucasssvaz
Copy link
Collaborator Author

@Jason2866 Could you check please if it fixes the issue ? I don't currently have the C2 environment configured on my computer.

Jason2866 added a commit to tasmota/arduino-esp32 that referenced this pull request Feb 9, 2024
@Jason2866
Copy link
Collaborator

@lucasssvaz The PR solves the issue. The "price" (used additionally resources) for the encrypt feature which is probably used very seldom is imho to high.

@lucasssvaz
Copy link
Collaborator Author

There only will be additional uses of resources for C2 as the functions from mbedtls are replaced with esp ones when hardware acceleration is available. We discussed it in the meeting and it is an acceptable solution for now. In the future we will remove the mbedtls dependency.

@lucasssvaz lucasssvaz added the Status: Pending Merge Pull Request is ready to be merged label Feb 9, 2024
@me-no-dev me-no-dev merged commit 58bea5c into espressif:master Feb 9, 2024
46 checks passed
@lucasssvaz lucasssvaz deleted the fix/aes branch March 19, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants