Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix whitespace and C/C++ format #9182

Closed
wants to merge 12 commits into from

Conversation

lucasssvaz
Copy link
Collaborator

By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes

Checklist

  1. Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. Please update relevant Documentation if applicable
  4. Please check Contributing guide
  5. Please confirm option to "Allow edits and access to secrets by maintainers" when opening a Pull Request

This entire section above can be deleted if all items are checked.


Description of Change

Please describe your proposed Pull Request and it's impact.

Tests scenarios

Please describe on what Hardware and Software combinations you have tested this Pull Request and how.

(eg. I have tested my Pull Request on Arduino-esp32 core v2.0.2 with ESP32 and ESP32-S2 Board with this scenario)

Related links

Please provide links to related issue, PRs etc.

(eg. Closes #number of issue)

Copy link
Contributor

github-actions bot commented Jan 27, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Add ignored words":
    • summary looks empty
    • type/action looks empty
  • the commit message "Config files only":
    • summary looks empty
    • type/action looks empty
  • the commit message "Deleted Yaml linting":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix codespell config":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix spelling":
    • summary looks empty
    • type/action looks empty
  • the commit message "Make codespell manual":
    • summary looks empty
    • type/action looks empty
  • the commit message "Reformat pass 1":
    • summary looks empty
    • type/action looks empty
  • the commit message "Run only in pending merge tags":
    • summary looks empty
    • type/action looks empty
  • the commit message "[pre-commit.ci lite] apply automatic fixes":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

⚠️ Please consider squashing your 12 commits (simplifying branch history).
Messages
📖 This PR seems to be quite large (total lines of code: 114370), you might consider splitting it into smaller PRs

👋 Hello lucasssvaz, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 7218d6b

@lucasssvaz lucasssvaz changed the title Fix whitespace Fix whitespace and C/C++ format Jan 27, 2024
@lucasssvaz lucasssvaz added the hil_test Run Hardware Tests label Jan 28, 2024
@lucasssvaz lucasssvaz force-pushed the fix/whitespace_format branch from 82c25d9 to 7218d6b Compare January 28, 2024 03:35
@CLAassistant
Copy link

CLAassistant commented Jan 28, 2024

CLA assistant check
All committers have signed the CLA.

@VojtechBartoska VojtechBartoska added this to the 3.0.0-RC1 milestone Jan 30, 2024
@me-no-dev me-no-dev closed this Jan 31, 2024
@lucasssvaz lucasssvaz deleted the fix/whitespace_format branch February 1, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hil_test Run Hardware Tests Status: In Progress Issue is in progress Type: CI & Testing
Projects
Development

Successfully merging this pull request may close these issues.

4 participants