WiFiClient copy constructor

[JAndrassy]

WiFiClient has assignment operator defined and no copy constructor. Then I get a warning

implicitly-declared 'WiFiClient::WiFiClient(const WiFiClient&)' is deprecated [-Wdeprecated-copy]

on returning an existing client instance from a function as a return value.

This PR adds the copy constructor.

The copy-ability of implementations of the Client class is a feature of the 'Arduino language' to avoid use of pointers.

[SuGlider]

@JAndrassy - I can't reproduce the message implicitly-declared 'WiFiClient::WiFiClient(const WiFiClient&)' is deprecated [-Wdeprecated-copy]. The complier should use the implicit copy constructor whenever necessary.

Please provide more information:

• Arduino Core version used
• Compiler Xtensa, Risc-V (SoC? ESP32, C3)
• The simpler Sketch example that can reproduce the message.

[SuGlider]

Need more information about the use case that this PR solves.

[JAndrassy]

at the second look, I see it would be better to remove the assignment operator. it should not stop() the client. some other copy may still want to work with that connection.

about the warning:

https://en.cppreference.com/w/cpp/language/rule_of_three

#include <WiFi.h>

WiFiClient client;

WiFiClient getClient() {
  return client;
}

void setup() {
}
void loop() {
}

[SuGlider]

This is interesting... I'm using exactly the same IDE version and C3 with the same configuration.
But I get no error message.
The difference is that I'm using Windows 11.

[JAndrassy]

But I get no error message.

maybe

in IDE Preferences?

I use Eclipse so I did the extra experiment in Arduino IDE to show the warning there