Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add peripheral manager test #8811

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Conversation

lucasssvaz
Copy link
Collaborator

Description of Change

This PR aims to implement a test for the peripheral manager on the CI.

Tests scenarios

Tested locally with all DevKits.

@lucasssvaz lucasssvaz added Type: CI & Testing Area: Peripherals API Relates to peripheral's APIs. 3.0 migration issue relates to migration from 2.X to 3.X version labels Oct 26, 2023
@lucasssvaz lucasssvaz self-assigned this Oct 26, 2023
@lucasssvaz
Copy link
Collaborator Author

@SuGlider Feel free to use this to test the RMT bug.

@lucasssvaz lucasssvaz force-pushed the ci/periman_test branch 4 times, most recently from d119085 to 9c37020 Compare December 4, 2023 13:45
@lucasssvaz lucasssvaz added the hil_test Run Hardware Tests label Dec 5, 2023
@lucasssvaz lucasssvaz force-pushed the ci/periman_test branch 2 times, most recently from 1268669 to 8208a5c Compare December 5, 2023 17:23
@lucasssvaz lucasssvaz marked this pull request as ready for review December 5, 2023 19:30
@lucasssvaz lucasssvaz removed the 3.0 migration issue relates to migration from 2.X to 3.X version label Dec 5, 2023
@lucasssvaz lucasssvaz added the Status: Review needed Issue or PR is awaiting review label Dec 6, 2023
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment on lines +72 to +73
pinMode(uart1_rx_pin, INPUT_PULLUP);
pinMode(uart1_tx_pin, OUTPUT);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment, we should commit the gpio_reset_pin to not need this. As its always detaching peripheral for GPIO and then using the UART.

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Dec 6, 2023
@me-no-dev me-no-dev merged commit 429a72b into espressif:master Jan 16, 2024
233 checks passed
@lucasssvaz lucasssvaz deleted the ci/periman_test branch February 7, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Peripherals API Relates to peripheral's APIs. hil_test Run Hardware Tests Status: Pending Merge Pull Request is ready to be merged Type: CI & Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants