Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added example 'get mac address' #8618

Merged
merged 16 commits into from
Nov 29, 2023
Merged

Added example 'get mac address' #8618

merged 16 commits into from
Nov 29, 2023

Conversation

dpnebert
Copy link
Contributor

@dpnebert dpnebert commented Sep 8, 2023 •
edited
Loading

By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes

Checklist

  1. Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. Please update relevant Documentation if applicable
  4. Please check Contributing guide

This entire section above can be deleted if all items are checked.

Description of Change

Examples for how to get the default MAC address, and for different interfaces such as WiFi and BLE.

Tests scenarios

Ran the examples on multiple ESP32-WROOM-32E modules, each returned a unique address. And checked the default address against the address displayed after running the ESP-IDF command “ espefuse.py --port COM15 summary”

Related

#8609 (comment)

(eg. Closes #number of issue)

@CLAassistant
Copy link

CLAassistant commented Sep 8, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@SuGlider SuGlider self-assigned this Sep 10, 2023
@dpnebert
Copy link
Contributor Author

Hello! I just wanted to make sure I didn't need to do anything on my end. This is my first PR, so I am not entirely sure I am going about this correctly. If I missing anything, please let me know. Thank you!

@me-no-dev
Copy link
Member

Hi @dpnebert . Example is very nice and we will further comment on it soon. Please allow some time to finish other tasks :)

lucasssvaz
lucasssvaz requested changes Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@lucasssvaz lucasssvaz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the example! Here are some improvements that can be made.

Also don't forget to fill out the Pull request template. It helps us to better understand the idea behind the PR and the tests performed.

libraries/ESP32/examples/MacAddress/GetMacAddress/GetMacAddress.ino Outdated Show resolved Hide resolved
libraries/ESP32/examples/MacAddress/GetMacAddress/GetMacAddress.ino Outdated Show resolved Hide resolved
libraries/ESP32/examples/MacAddress/GetMacAddress/GetMacAddress.ino Outdated Show resolved Hide resolved
libraries/ESP32/examples/MacAddress/GetMacAddress/GetMacAddress.ino Outdated Show resolved Hide resolved
libraries/ESP32/examples/MacAddress/GetMacAddress/GetMacAddress.ino Outdated Show resolved Hide resolved
libraries/ESP32/examples/MacAddress/GetMacAddress/GetMacAddress.ino Outdated Show resolved Hide resolved
libraries/ESP32/examples/MacAddress/GetMacAddress/GetMacAddress.ino Outdated Show resolved Hide resolved
@dpnebert
Copy link
Contributor Author

Thank you for the suggestions. I am new to pull requests and because I am at work, I can't spend too much time learning how to do them, so I am winging it. I just appreciate all the resources and examples so I really want to make an attempt to contribute.

Do I copy/paste the Pull Request template in this same box I am typing in right now? Sorry for being a pain.

@lucasssvaz
Copy link
Collaborator

@dpnebert Don't worry. When you first open the PR, the description text box will be filled with a placeholder text. You can modify it to describe your PR. Take a look at #8630 for an example. If you forget to do it, you can just edit the PR description 😃

lucasssvaz
lucasssvaz approved these changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@lucasssvaz lucasssvaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@VojtechBartoska VojtechBartoska added this to the 3.0.0 milestone Sep 26, 2023
@lucasssvaz lucasssvaz added Status: Pending Merge Pull Request is ready to be merged Type: Example Issue is related to specific example. labels Oct 25, 2023
lucasssvaz
lucasssvaz requested changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@lucasssvaz lucasssvaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the warnings shown by the CI

@P-R-O-C-H-Y P-R-O-C-H-Y added Resolution: Awaiting response Waiting for response of author and removed Status: Pending Merge Pull Request is ready to be merged labels Oct 30, 2023
@SuGlider SuGlider requested a review from lucasssvaz November 27, 2023 17:17
@SuGlider
Copy link
Collaborator

@lucasssvaz - please conclude your review. The CI passes fine.

@SuGlider SuGlider removed the Resolution: Awaiting response Waiting for response of author label Nov 27, 2023
@SuGlider SuGlider added the Status: Pending Merge Pull Request is ready to be merged label Nov 27, 2023
@VojtechBartoska VojtechBartoska modified the milestones: 3.0.0, 3.0.0-Aplha3 Nov 28, 2023
@me-no-dev me-no-dev merged commit 595dc01 into espressif:master Nov 29, 2023
38 checks passed
@dpnebert dpnebert mentioned this pull request Feb 15, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atanisoft atanisoft atanisoft left review comments

@lucasssvaz lucasssvaz lucasssvaz approved these changes

Assignees

@SuGlider SuGlider

Labels
Status: Pending Merge Pull Request is ready to be merged Type: Example Issue is related to specific example.
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
3.0.0-Aplha3
Development

Successfully merging this pull request may close these issues.
8 participants
@dpnebert @CLAassistant @me-no-dev @lucasssvaz @SuGlider @atanisoft @VojtechBartoska @P-R-O-C-H-Y