Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ETH] Implement SPI support, multiple interfaces and more #8575

Merged
merged 2 commits into from
Oct 5, 2023
Merged

[ETH] Implement SPI support, multiple interfaces and more #8575

merged 2 commits into from
Oct 5, 2023

Conversation

me-no-dev
Copy link
Member

No description provided.

@VojtechBartoska VojtechBartoska added this to the 3.0.0 milestone Aug 28, 2023
@VojtechBartoska VojtechBartoska added Area: Peripherals API Relates to peripheral's APIs. Status: Review needed Issue or PR is awaiting review labels Aug 28, 2023
@felmue felmue mentioned this pull request Sep 7, 2023
Closed
1 task
P-R-O-C-H-Y
P-R-O-C-H-Y approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small formatting issues to be fixed. Else LGTM!
Tested ETH chips W5500, DM9051 and KZS8851SHL. All working well on both scenarios using Arduino SPI or ESP-IDF SPI.
Also tested SD WebServer over Ethernet on shared SPI bus with W5500. Everything working well.

libraries/Ethernet/src/ETH.cpp Outdated Show resolved Hide resolved
libraries/Ethernet/src/ETH.cpp Outdated Show resolved Hide resolved
libraries/Ethernet/src/ETH.cpp Outdated Show resolved Hide resolved
libraries/Ethernet/src/ETH.cpp Outdated Show resolved Hide resolved
libraries/Ethernet/src/ETH.cpp Outdated Show resolved Hide resolved
libraries/Ethernet/src/ETH.cpp Show resolved Hide resolved
libraries/Ethernet/src/ETH.cpp Outdated Show resolved Hide resolved
libraries/Ethernet/src/ETH.cpp Outdated Show resolved Hide resolved
libraries/Ethernet/src/ETH.cpp Outdated Show resolved Hide resolved
libraries/Ethernet/src/ETH.cpp Outdated Show resolved Hide resolved
@me-no-dev me-no-dev mentioned this pull request Oct 2, 2023
Closed
1 task
@luc-github luc-github mentioned this pull request Oct 2, 2023
Closed
@me-no-dev me-no-dev merged commit a371990 into esp-idf-v5.1-libs Oct 5, 2023
@me-no-dev me-no-dev deleted the feature/eth_spi branch October 5, 2023 12:01
@me-no-dev me-no-dev mentioned this pull request Oct 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

@SuGlider SuGlider Awaiting requested review from SuGlider

Assignees
No one assigned
Labels
Area: Peripherals API Relates to peripheral's APIs. Status: Review needed Issue or PR is awaiting review
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@me-no-dev @P-R-O-C-H-Y @VojtechBartoska