Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example: ResetReason2 #8105

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Example: ResetReason2 #8105

merged 2 commits into from
Dec 5, 2023

Conversation

mrengineer7777
Copy link
Collaborator

Description of Change

Improved reboot reason by using the IDF version that persists crash information.

Tests scenarios

Tested on arduino-esp32 core v2.0.7 with Feather ESP32.
Tested using VSCODE+PIO. I am attaching the PIO version of the key test files.

image

Related links

Resolves #8040 (already closed)
ResetReason2.zip

@CLAassistant
Copy link

CLAassistant commented Apr 21, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mrengineer7777 mrengineer7777 changed the title Create ResetReason2.ino Example: ResetReason2 Apr 21, 2023
@mrengineer7777 mrengineer7777 changed the base branch from master to esp-idf-v5.1-libs April 23, 2023 04:24
@mrengineer7777 mrengineer7777 changed the base branch from esp-idf-v5.1-libs to master April 24, 2023 15:50
@mrengineer7777
Copy link
Collaborator Author

Unable to target 3.0.0 branch without creating a new PR. There's no hurry on merging this PR. It can wait until 3.0.0 is merged with master.

@VojtechBartoska VojtechBartoska added the Type: Example Issue is related to specific example. label Apr 25, 2023
@VojtechBartoska VojtechBartoska added this to the 3.0.0 milestone Apr 25, 2023
PilnyTomas
PilnyTomas approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@PilnyTomas PilnyTomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on ESP32, S2, S3 and C3 and works ok.

@mrengineer7777
Copy link
Collaborator Author

Rebased on master. No code changes.

@VojtechBartoska VojtechBartoska added the Status: Pending Merge Pull Request is ready to be merged label May 15, 2023
@me-no-dev
Copy link
Member

@mrengineer7777 you should update this branch now :) 3.0.0 is in

@mrengineer7777
Copy link
Collaborator Author

Rebased on lastest master. No code changes.

@VojtechBartoska VojtechBartoska modified the milestones: 3.0.0, 3.0.0-Aplha3 Nov 28, 2023
@me-no-dev
Copy link
Member

@mrengineer7777 seems some conflicts showed up. Can you please fix them?

@me-no-dev me-no-dev removed the Status: Pending Merge Pull Request is ready to be merged label Nov 29, 2023
@mrengineer7777
Copy link
Collaborator Author

Rebased on master. No code changes.

@mrengineer7777
Copy link
Collaborator Author

@me-no-dev Checks passed.

I will note there are some warnings and at least one error (WiFi library missing references in "Arduino on macOS-latest", "Arduino on windows-latest") in the build logs, but they appear unrelated to my example. Not sure why they aren't flagged as build errors.

@me-no-dev
Copy link
Member

we need to fix windows and mac CI to error properly (and update the sketches it builds too), so do not worry about those. Sadly you missed the alpha3, but the example will make it to RC1

@me-no-dev me-no-dev merged commit 2696a12 into espressif:master Dec 5, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@me-no-dev me-no-dev me-no-dev left review comments

@PilnyTomas PilnyTomas PilnyTomas approved these changes

Assignees
No one assigned
Labels
Type: Example Issue is related to specific example.
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
3.0.0-RC1
Development

Successfully merging this pull request may close these issues.

rtc_get_reset_reason() doesn't work on C3 chipset (ESP32-C3)
5 participants
@mrengineer7777 @CLAassistant @me-no-dev @PilnyTomas @VojtechBartoska