Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zigbee): Fixes in handlers, destructors and co2 sensor delta reporting #10834

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

P-R-O-C-H-Y
Copy link
Member

Description of Change

This PR fixes:

  • CO2 sensor delta value in reporting to be correct. (float deltas will be supported in upcoming esp-zigbee-sdk version 1.6.2)
  • Fixed undeclared destructors for all EPs -> declared empty destructors as they are not used.
  • Added returns in Zigbee Handlers to avoid processing empty or failed messages.

Tests scenarios

Tested locally.

Related links

@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Jan 9, 2025
@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Review needed Issue or PR is awaiting review Area: Zigbee Issues and Feature Request about Zigbee labels Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 99448db

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C60⚠️ +1520.00⚠️ +0.03000.000.00
ESP32H20⚠️ +1520.00⚠️ +0.03000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C6ESP32H2
ExampleFLASHRAMFLASHRAM
Zigbee/examples/Zigbee_CarbonDioxide_Sensor⚠️ +1320⚠️ +1300
Zigbee/examples/Zigbee_Color_Dimmable_Light⚠️ +1080⚠️ +1080
Zigbee/examples/Zigbee_Color_Dimmer_Switch⚠️ +1040⚠️ +1040
Zigbee/examples/Zigbee_Dimmable_Light⚠️ +1080⚠️ +1060
Zigbee/examples/Zigbee_Occupancy_Sensor⚠️ +1060⚠️ +1040
Zigbee/examples/Zigbee_On_Off_Light⚠️ +1080⚠️ +1080
Zigbee/examples/Zigbee_On_Off_Switch⚠️ +1040⚠️ +1040
Zigbee/examples/Zigbee_Pressure_Flow_Sensor⚠️ +1520⚠️ +1520
Zigbee/examples/Zigbee_Scan_Networks⚠️ +800⚠️ +800
Zigbee/examples/Zigbee_Temp_Hum_Sensor_Sleepy⚠️ +1080⚠️ +1080
Zigbee/examples/Zigbee_Temperature_Sensor⚠️ +1080⚠️ +1080
Zigbee/examples/Zigbee_Thermostat⚠️ +1040⚠️ +1000

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Test Results

 62 files   62 suites   5m 41s ⏱️
 21 tests  21 ✅ 0 💤 0 ❌
154 runs  154 ✅ 0 💤 0 ❌

Results for commit 99448db.

♻️ This comment has been updated with latest results.

@me-no-dev me-no-dev added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Jan 10, 2025
@me-no-dev me-no-dev merged commit 8143717 into espressif:master Jan 10, 2025
74 of 78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Zigbee Issues and Feature Request about Zigbee Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants