Add IAS Zone Notification Message service to ZigbeeHandlers and ZigbeeEP.h #10821
Conversation
👋 Hello lsroka76, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
|
|
| @@ -138,4 +140,25 @@ static esp_err_t zb_cmd_default_resp_handler(const esp_zb_zcl_cmd_default_resp_m | |||
| return ESP_OK; | |||
| } | |||
|
|
|||
| static esp_err_t zb_cmd_ias_zone_status_change_handler(const esp_zb_zcl_ias_zone_status_change_notification_message_t *message) { | |||
| if (!message) { | |||
| log_e("Empty message"); | |||
There was a problem hiding this comment.
you need to return here, or you will get exception further down when trying to access the structure
There was a problem hiding this comment.
It needs to be fixed in all handlers. Will do it in separate PR.
There was a problem hiding this comment.
Since this is new code, why not fix this one here and you can still add a PR to fix the rest @P-R-O-C-H-Y
There was a problem hiding this comment.
Sure, I was thinking to do it the same way you proposed.
make addBoundDevice virtual for override
|
in order to process this PR, you need to sign the CLA and add a short description of what it's about. What is IAS Zone Notification and why it matters. |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Test Results 62 files 62 suites 5m 42s ⏱️ Results for commit 8a9dbfd. ♻️ This comment has been updated with latest results. |
Description of Change
This change will allow to handle SP_ZB_CORE_CMD_IAS_ZONE_ZONE_STATUS_CHANGE_NOT_ID in zb_action_handler and dispatch it to destination endpoint for further processing.
Tests scenarios
Tested on ESP32 C6 with Tuya open window sensors (TS0203).
Related links
eg. Closes #10794 of issue