Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESPmDNS: Add method for querying discovered service name #10819

Merged
merged 5 commits into from
Jan 7, 2025

Conversation

stefan-sherwood
Copy link
Contributor

By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes

Description of Change

Please describe your proposed Pull Request and it's impact.

Added method for getting service (instance) name of services discovered with mDNS

Tests scenarios

Please describe on what Hardware and Software combinations you have tested this Pull Request and how.

I have tested my Pull Request on Arduino-esp32 core v2.02 with ESP32 Dev board

(eg. I have tested my Pull Request on Arduino-esp32 core v2.0.2 with ESP32 and ESP32-S2 Board with this scenario)

Related links

Please provide links to related issue, PRs etc.

(eg. Closes #number of issue)

@CLAassistant
Copy link

CLAassistant commented Jan 6, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Add method for querying service name":
    • summary looks empty
    • type/action looks empty
  • the commit message "Added implementation for getting service name":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update mDNS-SD_Extended example to include service name":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello stefan-sherwood, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 25658e9

@stefan-sherwood stefan-sherwood marked this pull request as draft January 6, 2025 22:48
@stefan-sherwood stefan-sherwood marked this pull request as ready for review January 6, 2025 22:51
@me-no-dev me-no-dev added the Status: Review needed Issue or PR is awaiting review label Jan 7, 2025
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32P40‼️ +18K0.00‼️ +2.72000.000.00
ESP32S30⚠️ +3760.00⚠️ +0.04000.000.00
ESP32S20⚠️ +3760.00⚠️ +0.04000.000.00
ESP32C30‼️ +20K0.00‼️ +2.18000.000.00
ESP32C60‼️ +20K0.00‼️ +2.13000.000.00
ESP320⚠️ +3720.00⚠️ +0.04000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32P4ESP32S3ESP32S2ESP32C3ESP32C6ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
ESPmDNS/examples/mDNS-SD_Extended‼️ +16K0⚠️ +3760⚠️ +3760‼️ +18K0‼️ +18K0⚠️ +3720
ESPmDNS/examples/mDNS_Web_Server‼️ +18K0⚠️ +2840⚠️ +2760‼️ +20K0‼️ +20K0⚠️ +2840

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Test Results

 62 files   62 suites   5m 41s ⏱️
 21 tests  21 ✅ 0 💤 0 ❌
154 runs  154 ✅ 0 💤 0 ❌

Results for commit 25658e9.

♻️ This comment has been updated with latest results.

@me-no-dev me-no-dev added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Jan 7, 2025
@me-no-dev me-no-dev merged commit c23c786 into espressif:master Jan 7, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants