-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESPmDNS: Add method for querying discovered service name #10819
ESPmDNS: Add method for querying discovered service name #10819
Conversation
👋 Hello stefan-sherwood, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
Test Results 62 files 62 suites 5m 41s ⏱️ Results for commit 25658e9. ♻️ This comment has been updated with latest results. |
By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes
Description of Change
Please describe your proposed Pull Request and it's impact.
Added method for getting service (instance) name of services discovered with mDNS
Tests scenarios
Please describe on what Hardware and Software combinations you have tested this Pull Request and how.
I have tested my Pull Request on Arduino-esp32 core v2.02 with ESP32 Dev board
(eg. I have tested my Pull Request on Arduino-esp32 core v2.0.2 with ESP32 and ESP32-S2 Board with this scenario)
Related links
Please provide links to related issue, PRs etc.
(eg. Closes #number of issue)