Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(matter): Changes Matter Temperature Sensor to report Celsius #10759

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SuGlider
Copy link
Collaborator

Description of Change

Matter specification says that all temperatures are measured in Celsius.
This PR fixes all places where this information was open and makes sure that the code and commentaries are clear about it.

Tests scenarios

CI Only

Related links

related to PR #7432

@SuGlider SuGlider added the Area: Libraries Issue is related to Library support. label Dec 19, 2024
@SuGlider SuGlider added this to the 3.1.0 milestone Dec 19, 2024
@SuGlider SuGlider self-assigned this Dec 19, 2024
Copy link
Contributor

github-actions bot commented Dec 19, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "feat(matter): fixes matter temperature sensor endpoint to indicate celsius as measure unit":
    • summary appears to be too long

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello SuGlider, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against d482d87

@SuGlider SuGlider added the Status: Review needed Issue or PR is awaiting review label Dec 19, 2024
Copy link
Contributor

github-actions bot commented Dec 19, 2024

Test Results

 62 files   62 suites   5m 40s ⏱️
 21 tests  21 ✅ 0 💤 0 ❌
154 runs  154 ✅ 0 💤 0 ❌

Results for commit d482d87.

♻️ This comment has been updated with latest results.

Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S3💚 -1600.000.00000.000.00
ESP32S2💚 -2400.000.00000.000.00
ESP32C3💚 -2400.000.00000.000.00
ESP32C6💚 -1600.000.00000.000.00
ESP32💚 -1600.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
Matter/examples/MatterColorLight0000000000
Matter/examples/MatterCommissionTest0000000000
Matter/examples/MatterComposedLights0000000000
Matter/examples/MatterContactSensor0000000000
Matter/examples/MatterDimmableLight0000000000
Matter/examples/MatterEnhancedColorLight0000000000
Matter/examples/MatterFan0000000000
Matter/examples/MatterHumiditySensor0000000000
Matter/examples/MatterMinimum0000000000
Matter/examples/MatterOccupancySensor0000000000
Matter/examples/MatterOnIdentify0000000000
Matter/examples/MatterOnOffLight0000000000
Matter/examples/MatterOnOffPlugin0000000000
Matter/examples/MatterPressureSensor0000000000
Matter/examples/MatterSmartButon0000000000
Matter/examples/MatterTemperatureLight0000000000
Matter/examples/MatterTemperatureSensor💚 -160💚 -240💚 -240💚 -160💚 -160
Matter/examples/WiFiProvWithinMatter0000000000

@SuGlider SuGlider added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Dec 19, 2024
@SuGlider SuGlider modified the milestones: 3.1.0, 3.1.1 Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Libraries Issue is related to Library support. Status: Pending Merge Pull Request is ready to be merged
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

3 participants