-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use INPUT_PULLUP instead of INPUT #10730
Conversation
Tested on some of the popular S3 board bought from Amazon, the digitalRead of an INPUT pin is LOW, which stops the timer right after start. Setting it to INPUT_PULLUP will fix it.
👋 Hello leochen4891, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thank you @leochen4891 for the contribution!
Description of Change
The digitalRead of an INPUT pin is LOW, which stops the timer right after start.
Setting it to INPUT_PULLUP will fix it.
It aims to make repeat timer example work out of the box on some of the popular S3 boards.
Tests scenarios
Tested on ESP32-S3 with Arduino-esp32 core v3.0.7 using Arduino 2.3.4
Related links
https://www.amazon.com/dp/B0C9H7Y66W