-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(boards): add Waveshare ESP32-S3-Touch-AMOLED boards #10520
Conversation
👋 Hello wurongmin, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
Why can't the test board pass |
fb7c67c
to
22ce416
Compare
All 4 boards are the same. I suggest you combine them into 1 "ESP32-S3-Touch-AMOLED". Having multiple boards with the same VID and PID is also not a great idea. Please also look into why CI is failing for your boards |
You have not defined I2C pins: https://github.com/espressif/arduino-esp32/actions/runs/11515946102/job/32057623865?pr=10520#step:5:294 |
I'm sorry, they're not the same, PID's not the same |
@wurongmin why did you change the updated title? |
Because I thought this description would be better, but of course I think it's better to use your previous description. If this description is necessary, I apologize for my behavior. |
Hello, is there any issue here that I haven't handled well |
@P-R-O-C-H-Y Hello, do you have a minute |
Hi @wurongmin, how can I help? |
Is there any problem in my pull request that needs to be modified? I see that the pull request has not been merged yet |
Don't worry, we will process the PR as usual :) You have added the PR before the weekend so please be more patient. |
Well. |
Hi @wurongmin, as me-no-dev mentioned, you have same PIDs for all boards you are now adding in the |
Modified the PID
I forgot about that, but it's fixed now. |
Why did the motherboard test fail, what is the problem, and how to modify it |
@P-R-O-C-H-Y Hi, I was wondering, what's wrong with this |
A message is displayed indicating that the mainboard test fails |
1.I added four ESP32S3 products: ESP32-S3-Touch-AMOLED-1.43, ESP32-S3-Touch-AMOLED-1.64, ESP32-S3-Touch-AMOLED-1.91, and ESP32-S3-Touch-LCD-1.9.
2.Among them, the ESP32-S3-Touch-AMOLED-1.91 is already available online. The link is as follows: https://www.waveshare.net/shop/ESP32-S3-Touch-AMOLED-1.91.htm. The others will be available soon.
3.I believe many people will love our products for the ability to customize their own board names.This will further enhance our promotion.