Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(boards): add Waveshare ESP32-S3-Touch-AMOLED boards #10520

Closed
wants to merge 5 commits into from

Conversation

wurongmin
Copy link
Contributor

1.I added four ESP32S3 products: ESP32-S3-Touch-AMOLED-1.43, ESP32-S3-Touch-AMOLED-1.64, ESP32-S3-Touch-AMOLED-1.91, and ESP32-S3-Touch-LCD-1.9.
2.Among them, the ESP32-S3-Touch-AMOLED-1.91 is already available online. The link is as follows: https://www.waveshare.net/shop/ESP32-S3-Touch-AMOLED-1.91.htm. The others will be available soon.
3.I believe many people will love our products for the ability to customize their own board names.This will further enhance our promotion.

Copy link
Contributor

github-actions bot commented Oct 25, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Update boards.txt":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

Messages
📖 You might consider squashing your 5 commits (simplifying branch history).
📖 This PR seems to be quite large (total lines of code: 93304), you might consider splitting it into smaller PRs

👋 Hello wurongmin, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against efee06a

@wurongmin
Copy link
Contributor Author

Why can't the test board pass

@wurongmin wurongmin changed the title feat(waveshare): added 4 items esp32 feat(waveshare): added 4 items esp32 waveshare boards Oct 25, 2024
@me-no-dev
Copy link
Member

All 4 boards are the same. I suggest you combine them into 1 "ESP32-S3-Touch-AMOLED". Having multiple boards with the same VID and PID is also not a great idea. Please also look into why CI is failing for your boards

@me-no-dev me-no-dev changed the title feat(waveshare): added 4 items esp32 waveshare boards feat(boards): add Waveshare ESP32-S3-Touch-AMOLED boards Oct 25, 2024
@me-no-dev
Copy link
Member

@wurongmin
Copy link
Contributor Author

I'm sorry, they're not the same, PID's not the same

@wurongmin wurongmin changed the title feat(boards): add Waveshare ESP32-S3-Touch-AMOLED boards feat(boards): add added 3 items esp32 Waveshare boards Oct 25, 2024
@me-no-dev
Copy link
Member

@wurongmin why did you change the updated title?

@wurongmin
Copy link
Contributor Author

Because I thought this description would be better, but of course I think it's better to use your previous description. If this description is necessary, I apologize for my behavior.

@wurongmin wurongmin changed the title feat(boards): add added 3 items esp32 Waveshare boards feat(boards): add Waveshare ESP32-S3-Touch-AMOLED boards Oct 25, 2024
@wurongmin
Copy link
Contributor Author

Hello, is there any issue here that I haven't handled well

@wurongmin
Copy link
Contributor Author

@P-R-O-C-H-Y Hello, do you have a minute

@P-R-O-C-H-Y
Copy link
Member

@P-R-O-C-H-Y Hello, do you have a minute

Hi @wurongmin, how can I help?

@wurongmin
Copy link
Contributor Author

Is there any problem in my pull request that needs to be modified? I see that the pull request has not been merged yet

@P-R-O-C-H-Y
Copy link
Member

Is there any problem in my pull request that needs to be modified? I see that the pull request has not been merged yet

Don't worry, we will process the PR as usual :) You have added the PR before the weekend so please be more patient.

@wurongmin
Copy link
Contributor Author

Well.

@P-R-O-C-H-Y
Copy link
Member

Hi @wurongmin, as me-no-dev mentioned, you have same PIDs for all boards you are now adding in the boards.txt file.
So they are not matching the ones in their pins_arduino.h file. PTAL

@wurongmin
Copy link
Contributor Author

I forgot about that, but it's fixed now.

@wurongmin
Copy link
Contributor Author

Why did the motherboard test fail, what is the problem, and how to modify it

@wurongmin wurongmin closed this Nov 1, 2024
@wurongmin wurongmin reopened this Nov 1, 2024
@wurongmin
Copy link
Contributor Author

@P-R-O-C-H-Y Hi, I was wondering, what's wrong with this

@wurongmin
Copy link
Contributor Author

A message is displayed indicating that the mainboard test fails

@wurongmin wurongmin closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants