-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multiple boards of the Waveshare ESP32-S3-Touch-LCD-1.46 type #10482
Conversation
Delete old files
Add new board
Add new board
👋 Hello Sail-211010, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
Hello, can you please change the name of the PR to more specific one? Also please add more details into PR description. Usually boards are added in seperate PRs. Did you check all already included boards? |
@VojtechBartoska Hi,I have checked the uploaded file and found nothing wrong for the time being. Please contact me if you find anything wrong. |
Thanks, we will review |
waveshare_esp32_s3_touch_lcd_185_box.build.mcu=esp32s3 | ||
waveshare_esp32_s3_touch_lcd_185_box.build.core=esp32 | ||
waveshare_esp32_s3_touch_lcd_185_box.build.variant=waveshare_esp32_s3_touch_lcd_185_box | ||
waveshare_esp32_s3_touch_lcd_185_box.build.board=WAVESHARE_ESP32_S3_TOUCH_LCD_185_Box |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the board name, as its not fully uppercase
waveshare_esp32_s3_touch_lcd_185_box.build.board=WAVESHARE_ESP32_S3_TOUCH_LCD_185_Box | |
waveshare_esp32_s3_touch_lcd_185_box.build.board=WAVESHARE_ESP32_S3_TOUCH_LCD_185_BOX |
@Sail-211010 I see you adding a lot of boards, but the pins_arduino.h file is for some boards common, and you only specify the SPI, I2C, UART and Analog+touch pins. It would be better for your users if you can add also more pins definitions. |
@P-R-O-C-H-Y I communicated with other engineers before and planned to define it in the example for developers to interpret the program. If there is any change in the relevant scheme in the future, I will modify the information again, and I may trouble you again. Thank you again |
But if you define it there, you can already use the pins definition in the example and will be more useful for users. But ofc, it's your decision. Take a look for example on our esp32-s3-usbotg board pins definition. |
Delete old files, modify the definition of the case error
Modify the definition of the case error
@P-R-O-C-H-Y Due to the large size of the file, I could not edit the file online, so I deleted the file and re-uploaded it, having modified the capitalization problem you raised(Updated boards.txt) |
yes,I know what you mean, I have designed this aspect on the board before, but I modified it to the current one before uploading. If necessary, I will launch a PR request next time, thank you for your trouble |
Would be nice to have that updated in future :) Thanks |
Sure. I'll keep up with the situation |
Hello, is there any other file error in the current progress that I need to modify |
Added several boards,Here are the boards I added this time:
Waveshare ESP32-S3-Touch-LCD-1.46
Waveshare ESP32-S3-LCD-1.46
Waveshare ESP32-S3-LCD-1.85
Waveshare ESP32-S3-Touch-LCD-1.85-Box
Waveshare ESP32-S3-LCD-1.47
Waveshare ESP32-S3-Touch-LCD-2.1
Waveshare ESP32-S3-Touch-LCD-2.8
Waveshare ESP32-S3-Relay-6CH