Backport: ArduinoOTA upload intermittent failure fixed

Backport of #4657
espressif · Feb 5, 2024 · 6aaa63c · 6aaa63c
1 parent de1774b
commit 6aaa63c
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/libraries/ArduinoOTA/src/ArduinoOTA.cpp b/libraries/ArduinoOTA/src/ArduinoOTA.cpp
@@ -287,7 +287,7 @@ void ArduinoOTAClass::_runUpdate() {
         if (!waited){
             if(written && tried++ < 3){
                 log_i("Try[%u]: %u", tried, written);
-                if(!client.printf("%u", written)){
+                if(!client.printf("%lu", written)){
                     log_e("failed to respond");
                     _state = OTA_IDLE;
                     break;
@@ -315,14 +315,18 @@ void ArduinoOTAClass::_runUpdate() {
         size_t r = client.read(buf, available);
         if(r != available){
             log_w("didn't read enough! %u != %u", r, available);
+	    if((int32_t) r<0) {
+	        delay(1);
+	        continue;  	//let's not try to write 4 gigabytes when client.read returns -1
+	    }
         }
 
         written = Update.write(buf, r);
         if (written > 0) {
             if(written != r){
                 log_w("didn't write enough! %u != %u", written, r);
             }
-            if(!client.printf("%u", written)){
+            if(!client.printf("%lu", written)){
                 log_w("failed to respond");
             }
             total += written;