Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate out PHY initialization. #2534

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

Frostie314159
Copy link
Contributor

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • I have added necessary changes to user code to the Migration Guide.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

This PR aims to provide a unified way of initializing the PHY. So far, only radio clock handling has been overhauled.

Testing

@Frostie314159
Copy link
Contributor Author

So far, I have only partially implemented shared radio clock control. I haven't updated esp-wifi yet, since I wasn't sure if this design is ok for everyone, so feedback is welcome.

@bugadani
Copy link
Contributor

Besides a couple of stylistic nitpicks I'll not list, I think the direction here is all right, although I don't see how upcoming work may change things around this.

@Frostie314159
Copy link
Contributor Author

Ok! Glad to hear that. The reason I made the PHY status static is, because next I want to implement splitting the control over the radio clocks for the individual modems, and the PHY still needs to be controlled centrally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants