Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update esp-synopsys-usb-otg #1427

Closed
wants to merge 2 commits into from

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Apr 12, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • My changes were added to the CHANGELOG.md in the proper section.

Extra:

Pull Request Details 📖

Description

There was a fix for esp-synopsys-usb-otg here: esp-rs-compat/synopsys-usb-otg#1
This includes that fix as a GIT dependency for now. For the next HAL release we'll need to have a new release eso-synopsys-usb-otg, too

Testing

Run the existing example and verify it still works as before

Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but just out of curiosity, is there any reason not to cut a release right now?

@jessebraham
Copy link
Member

LGTM, but just out of curiosity, is there any reason not to cut a release right now?

Yeah unless we expect changes to that library in the next week or two, probably makes sense to just publish it now and be done with it.

@bjoernQ
Copy link
Contributor Author

bjoernQ commented Apr 12, 2024

I can do a release maybe early next week just in case someone notices some bad newly introduced behavior (don't expect that). Could probably be a patch release?

@bjoernQ
Copy link
Contributor Author

bjoernQ commented Apr 16, 2024

Closing this ... there is a patch release now. While not really needed will create a PR to use it

@bjoernQ bjoernQ closed this Apr 16, 2024
@bjoernQ bjoernQ deleted the use-git-for-esp-synopsys-usb-otg branch November 26, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants