Cleanups and esp-hal references #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessebraham
approved these changes
Feb 28, 2024
SergioGasquez
approved these changes
Mar 4, 2024
mildsunrise
added a commit
to mildsunrise/book-1
that referenced
this pull request
Mar 29, 2024
esp-rs#145 updated the code snippet to remove a bunch of code that is no longer needed, but did not remove the bullet point from the explanation, making it confusing to read. it says "The next block ..." but there is no such block.
MabezDev
pushed a commit
that referenced
this pull request
Mar 30, 2024
#145 updated the code snippet to remove a bunch of code that is no longer needed, but did not remove the bullet point from the explanation, making it confusing to read. it says "The next block ..." but there is no such block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was mostly chip agnostic already, which made this really easy! I did read through the content again though and found some outdated stuff so I addressed that here too.
Closes esp-rs/esp-hal#1218