Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new test for mirroring with nested states #7

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

uturuncoglu
Copy link

This PR aims to add new NUOPC application prototype to test new mirroring option transferAllAsNests.

@uturuncoglu
Copy link
Author

@theurich I add a new simple prototype app for testing new option for mirroring. In this case, ocean component sends sst and atmosphere model extracts the nested state to reach the field provided by ocean component. I used existing miroring test in here but I remove lots of things from it to make it simple and understandable.

@uturuncoglu
Copy link
Author

@theurich this works without any issue in one processor but it seems handing if I use multiple. I could not understand way but if you have any idea or seeing anything missing just let me know. I'll also try to fix it.

@uturuncoglu
Copy link
Author

@theurich Okay. It is working if I comment following lines from the esm.F90.

diff --git a/AtmOcnMirrorFieldsNestedProto/esm.F90 b/AtmOcnMirrorFieldsNestedProto/esm.F90
index a1270d3..0123295 100644
--- a/AtmOcnMirrorFieldsNestedProto/esm.F90
+++ b/AtmOcnMirrorFieldsNestedProto/esm.F90
@@ -9,8 +9,8 @@
 !==============================================================================
 
 ! For testing with threading keep one or both SETVM macros active
-#define WITH_ATM_SETVM
-#define WITH_OCN_SETVM
+!#define WITH_ATM_SETVM
+!#define WITH_OCN_SETVM
 
 ! For testing with partially overlapping components keep one active, other _off
 #define WITH_ATM_PETLIST_off

I am not sure this part is necessary. Do we want to also test this with threading. Since editing mirroring test is testing threading maybe it would be nice to see this simple. Anyway, let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant