fix: minor glitch in markdown ast preview #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eslint-code-explorer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
In tightly packed areas when we have more than 3 keys we might actually want to add ellipsis to the text?
| before overflow ellipsis | after overflow ellipsis |
|---|---|
 |
 |
There was a problem hiding this comment.
I added a minimum height and overflow scroll to avoid this issue.
|
can you resolve conflicts in this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
What changes did you make? (Give an overview)
In the Markdown editor, long values were overlapping with their corresponding keys. Added a generic fix to resolve this issue.
Related Issues
Is there anything you'd like reviewers to focus on?
I have reviewed the changes myself, and I would request the reviewers to check for any corner cases to ensure that none of the existing styles or functionalities are not affected.