fix some error #3819
Open
fix some error #3819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix the error of muc_rooms and muc_light_rooms
|
Could you describe in more detail, what bug this PR is supposed to fix, and how to reproduce this issue? |
|
fixed the syntax mistake in the mysql.sql to run the old script mysql.sql to create table on MySQL, you will see the error. |
We are testing MongooseIM in CircleCI with MySQL 8.0.30, and there is no error. What is your MySQL version? |
| @@ -359,11 +359,12 @@ CREATE TABLE muc_light_blocking( | |||
| CREATE INDEX i_muc_light_blocking_su USING BTREE ON muc_light_blocking(lserver, luser); | |||
|
|
|||
| CREATE TABLE muc_rooms( | |||
| id SERIAL, | |||
| id BIGINT UNSIGNED NOT NULL AUTO_INCREMENT, | |||
There was a problem hiding this comment.
https://dev.mysql.com/doc/refman/8.4/en/numeric-type-syntax.html
Please have a look SERIAL have same meaning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses # fix the error of muc_rooms and muc_light_rooms
Proposed changes include: