Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add seg to Observation, read it in medsreaders #235

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

esheldon
Copy link
Owner

closes #233

@esheldon
Copy link
Owner Author

Is this an issue with the version of metadetect?

@beckermr
Copy link
Collaborator

Yeah just add det bands to that list.

beckermr and others added 2 commits December 10, 2022 21:53
cseg is the coadd seg composited onto the single epoch frame
@esheldon
Copy link
Owner Author

cseg isn't that useful, I forgot it sets the default value to the id of the object rather than zero

This one just interpolates coadd seg
@beckermr
Copy link
Collaborator

So uberseg in the meds readers always uses the coadd seg map. It looks like this class will default to use the seg on the obs which in principle will be different. Do we care about this?

@esheldon
Copy link
Owner Author

The default is seg in the single epoch image

@esheldon
Copy link
Owner Author

Are you proposing that the default change if uberseg is used for weight type?

@beckermr
Copy link
Collaborator

That's one way to make things less confusing possibly. I think all of the weight types that rely on a seg map use the coadd one so we might want to do this generally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add optional seg for Observations and read with medsreaders
2 participants