ENH add moment weight sums to output #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckermr
commented
Jul 19, 2022
beckermr
commented
Jul 19, 2022
beckermr
commented
Jul 19, 2022
beckermr
commented
Jul 19, 2022
beckermr
commented
Jul 19, 2022
beckermr
commented
Jul 19, 2022
beckermr
changed the title
esheldon
requested changes
Jul 21, 2022
BUG use area norm for all gauss mom things
|
OK @esheldon This one is ready for another look. I renamed everything. Note that metadetect won't pass until we push a change to that repo. I'll do that once we release ngmix 2.1 which should be sometime today hopefully. |
|
Does this need the other PR to pass tests? |
|
sorry, getting confused on PRs |
|
OK, the mdet regression won't pass until both PRs are merged |
esheldon
approved these changes
Jul 21, 2022
|
Mdet won't pass until it is updated to use sums instead of mom. So ignore that test for now. |
beckermr
commented
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the overall moment weight function normalization to fix a bug in mdet where this is ignored when combining shapes.
To do: