ENH apodize the pre-PSF moments #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This one is ready for review! |
esheldon
requested changes
Nov 29, 2021
|
|
||
|
|
||
| @pytest.mark.parametrize("flux_factor", [1e2, 1e3, 1e5]) | ||
| def test_prepsfmom_apodize(flux_factor): |
There was a problem hiding this comment.
They are better, but how good are they? Does the zero case have bad ringing, and is the resulting moments very bad, but not so for the apodized?
I wonder if the ringing would also produce spurious detections.
There was a problem hiding this comment.
The differences can be significant for stamps with bright sources on the edge.
I don't get the spurious detection question. We aren't detecting anything here.
There was a problem hiding this comment.
Yeah, I know you aren't detecting but I'm curious if one would see spurious detections if one was detecting. Anyway, out of scope for this.
esheldon
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds apodization for the pre-PSF moments and tests that it does the right thing.