-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add qs codemod #82
Conversation
I think throwing with a clear error message is fine 👍 |
This is awkward 😅 #83 |
James and I had a long discussion about this on the e18e discord, and we concluded that migrating |
No worries, if that's the direction we're going with! |
I think it's fine if we bail on these cases/if we can't codemod it
Hm that would be a breaking change in behavior, I'm ok with moving consumers off of it, but maybe we should add some logging to let them know about it?
I think thats fine yeah |
i think that would be sensible the option leads to all sorts of bugs and weird behaviours so we should 100% be moving people off it. ill see if i can get it to wrap with |
d54932d
to
8930e34
Compare
@thepassle i've done the following:
|
Adds a codemod for migrating from `qs` to `picoquery`. Some options qs offers are not available. Currently, this mod will not warn on those but should in future.
Adds a codemod for migrating from
qs
topicoquery
.Some options qs offers are not available. Currently, this mod will not warn on those but should in future.
Draft until we decide these things:
encode: false
is set, should we replace withdecodeURIComponent(stringify(obj))
? (encode
is a pretty bad option to have so ideally we should just move consumers off it)