-
Notifications
You must be signed in to change notification settings - Fork 27
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
8 changed files
with
184 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
import jscodeshift from 'jscodeshift'; | ||
import { removeImport } from '../shared.js'; | ||
|
||
/** | ||
* @typedef {import('../../types.js').Codemod} Codemod | ||
* @typedef {import('../../types.js').CodemodOptions} CodemodOptions | ||
*/ | ||
|
||
/** | ||
* @param {CodemodOptions} [options] | ||
* @returns {Codemod} | ||
*/ | ||
export default function (options) { | ||
return { | ||
name: 'is-number-object', | ||
transform: ({ file }) => { | ||
const j = jscodeshift; | ||
const root = j(file.source); | ||
|
||
removeImport('is-number-object', root, j); | ||
|
||
// Replace all calls to isNumber with Object.prototype.toString.call | ||
root | ||
.find(j.CallExpression, { | ||
callee: { | ||
type: 'Identifier', | ||
name: 'isNumber', | ||
}, | ||
}) | ||
.replaceWith((path) => { | ||
const arg = path.node.arguments[0]; | ||
return j.callExpression( | ||
j.memberExpression( | ||
j.memberExpression( | ||
j.memberExpression( | ||
j.identifier('Object'), | ||
j.identifier('prototype'), | ||
), | ||
j.identifier('toString'), | ||
), | ||
j.identifier('call'), | ||
), | ||
[arg], | ||
); | ||
}) | ||
.forEach((path) => { | ||
const parent = path.parent.node; | ||
if (j.BinaryExpression.check(parent)) { | ||
parent.operator = '==='; | ||
parent.right = j.literal('[object Number]'); | ||
} else if ( | ||
j.CallExpression.check(parent) && | ||
parent.arguments.length === 1 | ||
) { | ||
const newExpression = j.binaryExpression( | ||
'===', | ||
path.node, | ||
j.literal('[object Number]'), | ||
); | ||
parent.arguments[0] = newExpression; | ||
} | ||
}); | ||
|
||
return root.toSource({ quote: 'single' }); | ||
}, | ||
}; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
var assert = require('assert'); | ||
|
||
assert.notOk(Object.prototype.toString.call(undefined) === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call(null) === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call(false) === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call(true) === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call('foo') === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call(function () {}) === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call([]) === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call({}) === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call(/a/g) === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call(new RegExp('a', 'g')) === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call(new Date()) === '[object Number]'); | ||
|
||
assert.ok(Object.prototype.toString.call(42) === '[object Number]'); | ||
assert.ok(Object.prototype.toString.call(NaN) === '[object Number]'); | ||
assert.ok(Object.prototype.toString.call(Infinity) === '[object Number]'); | ||
assert.ok(Object.prototype.toString.call(new Number(42)) === '[object Number]'); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
var isNumber = require('is-number-object'); | ||
var assert = require('assert'); | ||
|
||
assert.notOk(isNumber(undefined)); | ||
assert.notOk(isNumber(null)); | ||
assert.notOk(isNumber(false)); | ||
assert.notOk(isNumber(true)); | ||
assert.notOk(isNumber('foo')); | ||
assert.notOk(isNumber(function () {})); | ||
assert.notOk(isNumber([])); | ||
assert.notOk(isNumber({})); | ||
assert.notOk(isNumber(/a/g)); | ||
assert.notOk(isNumber(new RegExp('a', 'g'))); | ||
assert.notOk(isNumber(new Date())); | ||
|
||
assert.ok(isNumber(42)); | ||
assert.ok(isNumber(NaN)); | ||
assert.ok(isNumber(Infinity)); | ||
assert.ok(isNumber(new Number(42))); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
var assert = require('assert'); | ||
|
||
assert.notOk(Object.prototype.toString.call(undefined) === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call(null) === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call(false) === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call(true) === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call('foo') === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call(function () {}) === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call([]) === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call({}) === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call(/a/g) === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call(new RegExp('a', 'g')) === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call(new Date()) === '[object Number]'); | ||
|
||
assert.ok(Object.prototype.toString.call(42) === '[object Number]'); | ||
assert.ok(Object.prototype.toString.call(NaN) === '[object Number]'); | ||
assert.ok(Object.prototype.toString.call(Infinity) === '[object Number]'); | ||
assert.ok(Object.prototype.toString.call(new Number(42)) === '[object Number]'); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
import assert from 'assert'; | ||
|
||
assert.notOk(Object.prototype.toString.call(undefined) === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call(null) === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call(false) === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call(true) === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call('foo') === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call(function () {}) === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call([]) === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call({}) === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call(/a/g) === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call(new RegExp('a', 'g')) === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call(new Date()) === '[object Number]'); | ||
|
||
assert.ok(Object.prototype.toString.call(42) === '[object Number]'); | ||
assert.ok(Object.prototype.toString.call(NaN) === '[object Number]'); | ||
assert.ok(Object.prototype.toString.call(Infinity) === '[object Number]'); | ||
assert.ok(Object.prototype.toString.call(new Number(42)) === '[object Number]'); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
import assert from 'assert'; | ||
import isNumber from 'is-number-object'; | ||
|
||
assert.notOk(isNumber(undefined)); | ||
assert.notOk(isNumber(null)); | ||
assert.notOk(isNumber(false)); | ||
assert.notOk(isNumber(true)); | ||
assert.notOk(isNumber('foo')); | ||
assert.notOk(isNumber(function () {})); | ||
assert.notOk(isNumber([])); | ||
assert.notOk(isNumber({})); | ||
assert.notOk(isNumber(/a/g)); | ||
assert.notOk(isNumber(new RegExp('a', 'g'))); | ||
assert.notOk(isNumber(new Date())); | ||
|
||
assert.ok(isNumber(42)); | ||
assert.ok(isNumber(NaN)); | ||
assert.ok(isNumber(Infinity)); | ||
assert.ok(isNumber(new Number(42))); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
import assert from 'assert'; | ||
|
||
assert.notOk(Object.prototype.toString.call(undefined) === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call(null) === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call(false) === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call(true) === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call('foo') === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call(function () {}) === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call([]) === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call({}) === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call(/a/g) === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call(new RegExp('a', 'g')) === '[object Number]'); | ||
assert.notOk(Object.prototype.toString.call(new Date()) === '[object Number]'); | ||
|
||
assert.ok(Object.prototype.toString.call(42) === '[object Number]'); | ||
assert.ok(Object.prototype.toString.call(NaN) === '[object Number]'); | ||
assert.ok(Object.prototype.toString.call(Infinity) === '[object Number]'); | ||
assert.ok(Object.prototype.toString.call(new Number(42)) === '[object Number]'); |