Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagram for rotated surface code #319

Closed
wants to merge 10 commits into from

Conversation

ehua7365
Copy link

Added a diagram and caption for rotated_surface.
Also corrected a minor typo in analog_stabilizer.

Modified Codes:

Rotated surface code:

  • Created directory for entry
  • Added a SVG figure
  • Included the figure and a caption in the entry itself

Analog stabilizer code:

  • Corrected a typo where the word "a set" was repeated twice.

Checklist:

I remembered to:

  • Include relevant citations I could think of (with \cite{...})

  • Create links to the other referenced codes (with
    \hyperref[code:...]{...})

  • Update the relevant meta changelog fields with my user_id (see
    users/users_db.yml; add yourself in the PR if you aren't there already)

@ehua7365 ehua7365 marked this pull request as ready for review July 17, 2023 20:40
@phfaist
Copy link
Member

phfaist commented Aug 14, 2023

Hi, I gotta apologize for the mysterious failing test - I finally found that it's a bug in the rendering code which uses the first paragraph of the description in various places (e.g. snippets in code lists). When it tries to render that first paragraph on its own, it encounters an unknown reference. I'm going to update the site rendering code to ignore unresolved references in those snippets.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the very pretty figure! Do you think you would be able to crop it so there is no margin on its sides? In Inkscape it's something like Document Properties -> Resize to content. Thanks!

@valbert4
Copy link
Member

Thanks! I had to add manually but it's in there now.

@valbert4 valbert4 closed this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants