Get plugin activation order from plugins excluding unwanted core plugins #1601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Updated/refactored to fix the issue while still passing all tests. |
|
FWIW this fix works, and I have it hacked in manually, and hope it is merged eventually. |
|
Can we get this merged please 🙏 |
…gin from loading or activating based on CORE_PLUGINS, and update code to ensure passing tests
|
@ostracon Thank you for the fix. I added a few commits to have linting pass. @tkratky I appreciate your PR provided a sample config to help me fully understand what this was addressing. @deborahgu and @kayman-mk thank for your patience on waiting for this to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change to
get_plugins_activation_order, which should result in errbot properly honouring theCORE_PLUGINSconfig directive, which I believe is causing the issue outlined in #1591.