Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped OTP versions #170

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Bumped OTP versions #170

merged 1 commit into from
Feb 21, 2024

Conversation

ariel-anieli
Copy link

@ariel-anieli ariel-anieli commented Feb 20, 2024

  • aligned OTP versions with Debian
  • keeps versions from bullseye (old stable) to sid (unstable).
$ curl --silent https://packages.debian.org/search?keywords=erlang | \
  sed -ne '/Package erlang</,/<\/ul>/{/<\/a>/p; /br/p}' | \
  sed -e 's/<a.*$//' | \
  perl -0777 -pE 's/<li class="(\w+)">\n/$1/g; s/<br>([^\s]+)/$1/g; s/\+.*(?=\n)//g' | \
  sed -e '1i name otp-version' | \
  column -t
name          otp-version
buster        1:22.2.7
bullseye      1:23.2.6
bookworm      1:25.2.3
trixie        1:25.3.2.8
sid           1:25.3.2.8
experimental  1:26.2.1

$ curl -I  https://packages.debian.org/search?keywords=erlang
HTTP/2 200
date: Tue, 20 Feb 2024 22:21:53 GMT
server: Apache
last-modified: Tue, 20 Feb 2024 21:50:40 GMT
vary: Accept-Encoding,negotiate,accept-language
x-clacks-overhead: GNU Terry Pratchett
expires: Wed, 21 Feb 2024 09:04:02 +0000
x-content-type-options: nosniff
x-frame-options: sameorigin
referrer-policy: no-referrer
x-xss-protection: 1
permissions-policy: interest-cohort=()
strict-transport-security: max-age=15552000
age: 1873
content-length: 184625
content-type: text/html; charset=UTF-8

@ariel-anieli
Copy link
Author

The unit tests failed in 26.2; I am checking where it comes from.

@ferd
Copy link
Collaborator

ferd commented Feb 21, 2024

The failure you get on eunit might simply be because of changes in dialyzer defaults in newer versions. You'll want to add a rebar.config file with {dialyzer, [{warnings, [no_unknown]}]} in there to make it ignore calls to unknown apps or functions, or alternatively add the missing apps to the set of analyzed entries, which is a bit more work.

@ariel-anieli ariel-anieli force-pushed the pr-otp-bump branch 3 times, most recently from a01e06b to 4d718ea Compare February 21, 2024 20:00
@ariel-anieli
Copy link
Author

Thanks for the hints; much appreciated. R26 compiles, no_unknown exists, but R25 fails: unknown is the default.

From what I see, the easiest way is to include the missing app. Should I add eunit to the deps where cf is?

* aligned OTP versions with Debian
* keeps versions from bullseye (old stable) to sid (unstable).

```
$ curl --silent https://packages.debian.org/search?keywords=erlang | \
  sed -ne '/Package erlang</,/<\/ul>/{/<\/a>/p; /br/p}' | \
  sed -e 's/<a.*$//' | \
  perl -0777 -pE 's/<li class="(\w+)">\n/$1/g; s/<br>([^\s]+)/$1/g; s/\+.*(?=\n)//g' | \
  sed -e '1i name otp-version' | \
  column -t
name          otp-version
buster        1:22.2.7
bullseye      1:23.2.6
bookworm      1:25.2.3
trixie        1:25.3.2.8
sid           1:25.3.2.8
experimental  1:26.2.1

$ curl -I  https://packages.debian.org/search?keywords=erlang
HTTP/2 200
date: Tue, 20 Feb 2024 22:21:53 GMT
server: Apache
last-modified: Tue, 20 Feb 2024 21:50:40 GMT
vary: Accept-Encoding,negotiate,accept-language
x-clacks-overhead: GNU Terry Pratchett
expires: Wed, 21 Feb 2024 09:04:02 +0000
x-content-type-options: nosniff
x-frame-options: sameorigin
referrer-policy: no-referrer
x-xss-protection: 1
permissions-policy: interest-cohort=()
strict-transport-security: max-age=15552000
age: 1873
content-length: 184625
content-type: text/html; charset=UTF-8
```
@ariel-anieli
Copy link
Author

The PR is good to go: OTP bumped to 25.3; for 26.2, I'll look how to use unknown and no_unknown in the same rebar.config.

@ferd ferd merged commit 5de3c80 into erlware:master Feb 21, 2024
3 checks passed
@ariel-anieli ariel-anieli deleted the pr-otp-bump branch February 21, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants