-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation #1
Conversation
to be reverted when erlef/otp_builds#1 is merged
to be reverted when erlef/otp_builds#1 is merged
to be reverted when erlef/otp_builds#1 is merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For clarity, should we mention how OpenSSL and wxWidgets are build and/or statically linked?
And what about "this is our strategy for updating OpenSSL if a vulnerability is found" (?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments but nothing that can't be turned into GitHub issues and done later. Approving...
dc6586e
to
c5b8020
Compare
@paulo-ferraz-oliveira @starbelly thank you for the feedback. Regarding https://github.com/jelly-beam/otp-macos, it is quite comprehensive and it's a great starting point. Now that you can see how I tried implementing this, we can consider the next steps. Would you rather:
? |
"merge changes from jelly-beam/otp-macos here", for me 👍 Some stuff can be adapted, I guess, but only if there's a need for it; as long as we have the builds here there's only a few details I'd update, but I don't think they'll change the base behaviour:
This said, I'd go with your current implementation; it's a good starting point and I can see a couple of advantages:
I'm also Ok with using |
☝️ That. Let's go with this PR, then roll in changes that were done in otp-macos, collaboratively. |
Sounds good, I’ll send some updates here soon! |
@wojtekmach Just to confirm, you are ready for this to be merged? |
Not quite yet, I'll merge this myself if that's OK. |
4972b43
to
38a0e79
Compare
7ef84cc
to
bb007d8
Compare
bb007d8
to
984a8ce
Compare
I have made the following changes:
I'm going to merge this as is to unblock others tasks but please feel free to keep the discussion going here or in other issues. Thanks everyone for reviewing this! |
This is the implementation of the OTP macOS builds proposal.
Updated README.md: https://github.com/erlef/otp_builds/blob/wm-initial/README.md
As you can see in commits list, the GitHub job automatically commits
builds/*.txt
changes.Builds can be manually triggered like this:
Example