Pull regions from styles #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f 'ActiveRecord' solo
Remove duplication by reusing existing method.
Fix condition to include Schema, using 'ActiveRecord::Base' instead o…
Extract another repository only concerned with locales: https://github.com/thoughtbot/paperclip-i18n A user of paperclip might choose to add `paperclip-i18n` as a dependency for their application, or copy over the related locale file into their project. This is a first step in splitting some parts of the codebase into other projects. Simple and relevant contributions like new translations might get lost in the shuffle of dozens of PRs awaiting for approval, that take time to review and merge. Locales are a simple enough problem to be handled in an external repository, where tests for consistency across translations run in less than a second, and PRs can almost trivially be merged in.
Remove locales from main repository
In preparation for Rails 5, which, when it is released, will make Rails 3.2 and 4.1 unsupported. See: * http://weblog.rubyonrails.org/2015/12/18/Rails-5-0-beta1/ * thoughtbot#2049
…ted-rails Removes Rails 3.2 and 4.1 support
TODO: Simpify lib/paperclip/storage/s3.rb See: * thoughtbot#2049
Remove AWS v1 support
…ethod These variables were introduced in: thoughtbot@6ea7c26512434a but their usage were canceled in: thoughtbot@c740fb171fe
File.exists? is deprecated and produces unecessary warning.
Replace File.exists? with File.exist? in paperclip.gemspec
Remove unused vars `column_(type|options)` from `remove_attachment` method
Updated copyright notices to 2016 [ci skip]
Relax mimemagic version constraint to ~> 0.3.0
- Also modify the appraisals to be more flexibly specified.
- The specs are '>= 1.16' and '< 4.0' because the major versions of
mime-types have steadily restricted the supported versions of Ruby at a
different rate than Rails. The Appraisal for Rails 5 can be specified as
either '>= 2.0, '< 4.0' or '~> 3.0' depending on how other gems restrict
mime-types versions.
- mime-types 1.x supports any version of Ruby, but no longer receives any
updates (it hit EOL on 27 October 2015).
- mime-types 2.x supports Ruby >= 1.9.2, but will only receive security
and data updates until 21 November 2017.
- mime-types 3.x supports Ruby >= 2.0 and is the active development
version of mime-types.
- The APIs that paperclip uses are compatible between all three versions of
mime-types.
Modify the Gemfile for testing with mime-types 3
The MD5 sum of an attachment is only necessary if the model has a corresponding _fingerprint column. If this column is absent, there is no need to calculate the MD5, which can be an expensive operation for large files. Accomplish this by deferring the fingerprint calculation using a block. If the _fingerprint column is absent, the block is never called, and the calculation is avoided.
Skip calculating fingerprint when it is not used
Remove attr_protected related specs (was removed in rails 4)
Related with thoughtbot#2122 [ci skip]
…lter to test for tempfile leakage in integration spec
replace URI escape with RFC2396_Parser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a change to allow specifying bucket and region per style in the s3 storage class