onUpdateInput for AutoComplete #142
Conversation
sachinmour
commented
Apr 23, 2017
sachinmour
commented
- onUpdateInput should execute regardless of dataSourceConfig.
- As we would like to have different methods for user select and user change, another function such onUpdateInput which is also available in material-ui core library, this would be a good addition.
* onUpdateInput should execute regardless of dataSourceConfig. * As we would like to have different methods for user select and user change, another function such onUpdateInput which is also available in material-ui core library, this would be a good addition.
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
==========================================
+ Coverage 76.31% 78.37% +2.06%
==========================================
Files 11 11
Lines 38 37 -1
==========================================
Hits 29 29
+ Misses 9 8 -1
Continue to review full report at Codecov.
|
| @@ -3,7 +3,7 @@ import createComponent from './createComponent' | |||
| import mapError from './mapError' | |||
|
|
|||
| export default createComponent(AutoComplete, ({ | |||
| input: { onChange, value }, | |||
| input: { onChange, value, onUpdateInput }, | |||
There was a problem hiding this comment.
onUpdateInput is not in input. input are callbacks that redux-form generates.
There was a problem hiding this comment.
correct.. i meant when you are overwriting the input by passing it as props..
maybe code should be more like..
if (onUpdateInput) {..}
|
@erikras @sachinmour are there any plans get this change into a release? |
|
@erikras any update on this? I can't get a basic async search going on autocomplete with the redux-form version. With or without a dataSourceConfig, it simply does not fire onUpdateComplete |
