Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc git hosting fixes #162

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Commits on Jun 28, 2012

  1. Configuration menu
    Copy the full SHA
    bc1962b View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2012

  1. Cache calls to 'entries'

    The Hosting adapter causes multiple calls to be sent to 'entries' on
    the git_adapter(repositories_controller_path#show_with_git_instructions
    adds a second (non vanilla chiliproject) call.
    
    As this method is very expensive, this has a performance impact we can
    avoid!
    
    It might be better to provide a dedicated method to the patched
    git_adapter to determine whether a repository is 'empty' or not
    rather than having to fetch the entries, but this will work for now.
    ciaranj committed Jun 29, 2012
    Configuration menu
    Copy the full SHA
    a709ab6 View commit details
    Browse the repository at this point in the history
  2. Avoid un-neccessary gitolite configuration updates

    There is some logic in update_repositories to avoid 'recursion'
    however this does not protect against the case where an
    observed change leads to multiple calls to update_repositories
    for the same project (or projects.)
    
    An example change that could cause this is is to add a *group*
    with commit rights as a project's member.  The update_repositories
    method will then get called for both the group's addition and
    each subsequent member of that group.  This change avoids those
    un-neccessary secondary calls.
    ciaranj committed Jun 29, 2012
    Configuration menu
    Copy the full SHA
    1057899 View commit details
    Browse the repository at this point in the history