Allow bandwidth graph colours to be set by theme

[lantis1008]

Pulls the "color" attribute of the label for each plot and applies it to the polyline object color and fill attributes

[lantis1008]

@d3fz
This may be of interest to the theme you are building.

#plot1_title
{
	color: blue;
}
#plot2_title
{
	color: red;
}
#plot3_title
{
	color: green;
}

[d3fz]

Nice. 👍

Can you provide any screenshots showing how it looks?

For some reason, it's not working on my end. When setting a different color, only the labels color change. This should also affect graphs color, right?

Clearing browser cache doesn't seem to fix it.

[lantis1008]

You took the changes from svg_bandwidth.js as well?
This is a quick change with softer colours

[d3fz]

This is a quick change with softer colours

Those graph colors look smooth on a dark background. Nice.

You took the changes from svg_bandwidth.js as well?

Yes.

After further testing, console was throwing TypeError: window.parent.getElementById is not a function on line 38 var titleEl = window.parent.getElementById("plot" + x + "_title");

Changing to window.parent.document.getElementById fixed the issue.

Testing random colors

---

Oddly enough, bandwidth_expand.sh header has some duplicate code:

gargoyle_header_footer -m -c "internal.css" -j gargoyle_header_footer -m -c "internal.css"

[lantis1008]

Thanks I’ll double check that error. I wasn’t seeing it.
What browser?

[d3fz]

Vivaldi (Chromium based).

Also tested with latest Chrome/Opera/Edge and Firefox Quantum. Same problem.

[lantis1008]

Thanks for pointing it out. Was a typo in the commit, was fine on my router (hence why i saw no bugs). Whoops.

[ericpaulbishop]

Looks great, merged.

[lantis1008]

Whoops. Accidentally pushed the theme as well.
I’ll do a commit to enable it for building later this week.

[d3fz]

I was about to make a comment on that, nice work on the horizontal menu bar by the way. Maybe now it should be possible/easier to address those two remaining themes in #654?

[lantis1008]

Definitely. They are next on my todo list :)