Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing some updates to workflow to see if it can run any tests #695

Merged
merged 54 commits into from
Jan 5, 2025
Merged

Testing some updates to workflow to see if it can run any tests #695

merged 54 commits into from
Jan 5, 2025

Conversation

zktuong
Copy link
Collaborator

@zktuong zktuong commented Jan 3, 2025 •
edited
Loading

This PR:

  1. updates and simplifies the github actions workflow with pixi
  2. fixes bugs with updated dependencies
  3. add example of custom color mapping
  4. bump version to v0.7.5
  5. fix bugs with annotate.py causing legends to be stuck off screen

zktuong added 28 commits January 3, 2025 11:59
@zktuong
hmm does this work in updating the workflow?
7daea07
@zktuong
try again
b79822f
@zktuong
black
bc2eee5
@zktuong
try
476cff2
@zktuong
Update pr-checks.yaml
54bdfb8
@zktuong
Update pr-checks.yaml
e5b7f22
@zktuong
Update docs.yaml
eac73f0
@zktuong
Update pr-checks.yaml
0af0f96
@zktuong
Update pr-checks.yaml
d9b79af
@zktuong
fix typo
a9c8e4e
@zktuong
Update annotate.py
efdcd5f
@zktuong
black
be94161
@zktuong
make sure mknotebooks is installed
5e87c25
@zktuong
add back jupyter dependencies
6830c8b
@zktuong
Update pr-checks.yaml
1f39174
@zktuong
change to pickle
2684bb4
@zktuong
does this still work?
f3a6719
@zktuong
what about this?
92dfd77
@zktuong
black
37d428c
@zktuong
Revert "what about this?"
2d34e2d 
This reverts commit 92dfd77.
@zktuong
activating seems unnecessary now
779ff3d
@zktuong
Update pr-checks.yaml
584314a
@zktuong
change to python 3.12
5aa2bb9
@zktuong
bump version and add new examples
cfde2d1
@zktuong
bug fis to moving legends
02b781a
@zktuong
Update annotate.py
85bb031
@zktuong
Update circos_node_labels.ipynb
46945bc
@zktuong
Update circos_node_labels.ipynb
a39a940
@zktuong zktuong marked this pull request as ready for review January 3, 2025 06:19
@zktuong zktuong requested a review from ericmjl January 3, 2025 06:20
@zktuong
Copy link
Collaborator Author

zktuong commented Jan 3, 2025

alright i think this PR is now pixi-ed!

ericmjl
ericmjl approved these changes Jan 3, 2025
View reviewed changes
Copy link
Owner

@ericmjl ericmjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have a few minor changes requested. I am going to pre-approve this PR!

.github/workflows/pr-checks.yaml Outdated Show resolved Hide resolved
.github/workflows/pr-checks.yaml Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
@zktuong
Copy link
Collaborator Author

zktuong commented Jan 3, 2025

pre-commit.ci run

@zktuong zktuong merged commit 2c2c114 into ericmjl:master Jan 5, 2025
17 checks passed
@zktuong zktuong deleted the update-workflow branch January 5, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericmjl ericmjl ericmjl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zktuong @ericmjl