Skip to content

Commit

Permalink
Update README for latest connect changes
Browse files Browse the repository at this point in the history
  • Loading branch information
erichlf committed Jun 4, 2024
1 parent d5fd47a commit cf57130
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
7 changes: 5 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -97,13 +97,16 @@ make assumptions about how you work.
-- start from scratch
remove_existing_container = true,
-- By default, if no extra config is added, following nvim_dotfiles are
-- installed: "https://github.com/LazyVim/starter"
-- installed: "https://github.com/erichlf/dotfiles"
-- This is an example for configuring other dotfiles inside the docker container
dotfiles_repository = "https://github.com/erichlf/dotfiles.git",
dotfiles_branch = "main", -- branch to clone from dotfiles_repository`
dotfiles_targetPath = "~/dotfiles", -- location to install dotfiles
dotfiles_intallCommand = "install.sh", -- script to run after dotfiles are cloned
shell = "bash", -- shell to use when executing commands
-- The particular binary to use for connecting to in the devcontainer
-- Most likely this should remain nvim
nvim_binary = "nvim",
},
keys = {
-- stylua: ignore
Expand Down Expand Up @@ -203,4 +206,4 @@ make test
5. [x] Add unit tests using plenary.busted lua module.
6. [ ] The logs printed in the floating window when preparing the Devcontainer
are saved and easy to access.
7. [ ] Convert bash scripts in lua code.
7. [x] Convert bash scripts in lua code.
2 changes: 0 additions & 2 deletions lua/devcontainer-cli/config.lua
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,6 @@ local default_config = {
-- The shell to use for executing command. Available sh, bash, zsh or any
-- other that uses '-c' to signify a command is to follow
shell = 'bash',
-- The name of the socket file to use
port = "7777",
}

local options
Expand Down

0 comments on commit cf57130

Please sign in to comment.