Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for apps that will change env['PATH_INFO'] #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gaganawhad
Copy link

problem: So I am using font_assets along with sidekiq and it seems that sidekiq's web interface is changing the value of env['PATH_INFO'] to a blank string, which then breaks things.

caveat: I am not at expert at RACK so I am not sure that this fixes the problem at the root. Also, I am not really sure if sidekiq should be changing the env.

This is a first attempt at a fix. The test suite passes. I am not sure if you want to add a test case for apps that change the env, so I didn't add one.

Another possible fix might be to allow for env['PATH_INFO'] to hold a blank string but then again, I am not exactly sure what exactly the culprit is.

@ericallam
Copy link
Owner

I just merged another patch that I think should solve this issue too. If you get a chance could you test it out and report back?

@jjb
Copy link

jjb commented Feb 25, 2014

i had this problem too, described here sidekiq/sidekiq#1514

the problem goes away with 01861d9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants